Repository navigation
Fix setup version - #12
Merged
Merged
Conversation
…ION string is kept in the setup.py where all other metadata for the package already ends up. To me, putting it in version_helper, which are really just utitilites, seems odd. The version.py contains some code to optionally update the version string on each import if the package is installed with 'setup.py' develop. 'import astropy' succeeds even if the version.py file is missing--though this situtation should only occur on initial setup, so maybe a warning should be issued in all other contexts.
…o not endlessly concatenate revisions
astrofrog
added a commit
that referenced
this pull request
Oct 14, 2011
Fix setup version. Fixes #8.
keflavich
referenced
this pull request
in keflavich/astropy
Oct 9, 2013
Fix setup version. Fixes #8.
taldcroft
referenced
this pull request
in taldcroft/astropy
Apr 25, 2014
Implementation of frames/low-level classes
cdeil
pushed a commit
to cdeil/astropy
that referenced
this pull request
Dec 17, 2014
Restore changes issed in rebase
mirca
pushed a commit
to mirca/astropy
that referenced
this pull request
Jun 22, 2017
add simple test case against numpy.convolve
jeffjennings
pushed a commit
to jeffjennings/astropy
that referenced
this pull request
Jul 2, 2025
Fixed links to docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This request illustrates my proposed solution to issue #8. There's plenty of room here for massaging, but I wanted to put something up as a starting point.
This fix has 3 advantages over the current situation: