Skip to content

Fix tight_layout for WCSAxes - #12418

Merged
astrofrog merged 7 commits into
astropy:mainfrom
dstansby:wcsaxes-tight-layout
Sep 8, 2022
Merged

astrofrog merged 7 commits into
astropy:mainfrom
dstansby:wcsaxes-tight-layout

Conversation

@dstansby

@dstansby dstansby commented Nov 5, 2021

Copy link
Copy Markdown
Contributor

Without doing a major refactoring of WCSAxes to make things work more like they do in Matplotlib, this fixes #8703

@Cadair

Cadair commented Nov 5, 2021 •

Copy link
Copy Markdown
Member

Should we write a figure test specifically showing tight_layout working?

@Cadair Cadair modified the milestones: v5.0, v5.0.1 Nov 5, 2021
@dstansby

dstansby commented Nov 5, 2021

Copy link
Copy Markdown
Contributor Author

Given this didn't change any existing tests, sounds good - I'm not sure which of the files under wcsaxes/tests it's best to add the tests to though, any thoughts?

@Cadair

Cadair commented Nov 5, 2021

Copy link
Copy Markdown
Member

pick one 🙈, the one with the most useful fixtures is probably the best, maybe test_images.py?

@pep8speaks

pep8speaks commented Nov 5, 2021 •

Copy link
Copy Markdown

Hello @dstansby 👋! It looks like you've made some changes in your pull request, so I've checked the code again for style.

There are no PEP8 style issues with this pull request - thanks! 🎉

Comment last updated at 2022-09-08 20:54:12 UTC

@pllim pllim added the Bug label Nov 22, 2021
@astrofrog astrofrog modified the milestones: v5.0.1, v5.0.2 Jan 27, 2022
@pllim pllim modified the milestones: v5.0.2, v5.0.3 Mar 10, 2022
@pllim pllim modified the milestones: v5.0.3, v5.0.4, v5.0.5 Mar 25, 2022
@github-actions github-actions Bot added the Close? Tell stale bot that this issue/PR is stale label May 28, 2022
@github-actions

Copy link
Copy Markdown
Contributor

Hi humans 👋 - this pull request hasn't had any new commits for approximately 4 months. I plan to close this in 30 days if the pull request doesn't have any new commits by then.

In lieu of a stalled pull request, please consider closing this and open an issue instead if a reminder is needed to revisit in the future. Maintainers may also choose to add keep-open label to keep this PR open but it is discouraged unless absolutely necessary.

If this PR still needs to be reviewed, as an author, you can rebase it to reset the clock.

If you believe I commented on this pull request incorrectly, please report this here.

@dstansby

Copy link
Copy Markdown
Contributor Author

I think this is worth pursusing - I don't have time to figure out how to update fiugre tests in astropy at the moment, but if someone else has the motivation to feel free to push to my branch or create a new branch+PR off this branch.

@astrofrog

Copy link
Copy Markdown
Member

I will need to rebase once #12630 is merged to get the latest infrastructure changes

@astrofrog
astrofrog merged commit 8e19236 into astropy:main Sep 8, 2022
@pllim

pllim commented Sep 8, 2022

Copy link
Copy Markdown
Member

Hmm... Did you break the autobackport bot? lol

@meeseeksdev backport to v5.0.x

@meeseeksdev backport to v5.1.x

meeseeksmachine pushed a commit to meeseeksmachine/astropy that referenced this pull request Sep 8, 2022
meeseeksmachine pushed a commit to meeseeksmachine/astropy that referenced this pull request Sep 8, 2022
astrofrog added a commit that referenced this pull request Sep 8, 2022
…418-on-v5.1.x

Backport PR #12418 on branch v5.1.x (Fix tight_layout for WCSAxes)
astrofrog added a commit that referenced this pull request Sep 8, 2022
…418-on-v5.0.x

Backport PR #12418 on branch v5.0.x (Fix tight_layout for WCSAxes)
@dstansby

dstansby commented Sep 9, 2022

Copy link
Copy Markdown
Contributor Author

Thanks a lot @astrofrog for finishing off my PRs!

@dstansby
dstansby deleted the wcsaxes-tight-layout branch September 9, 2022 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Close? Tell stale bot that this issue/PR is stale visualization.wcsaxes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tight_layout() doesn't work properly on plots with a WCSAxes projection

5 participants