Repository navigation
Fix tight_layout for WCSAxes - #12418
Conversation
|
Should we write a figure test specifically showing tight_layout working? |
|
Given this didn't change any existing tests, sounds good - I'm not sure which of the files under |
|
pick one 🙈, the one with the most useful fixtures is probably the best, maybe |
|
Hello @dstansby 👋! It looks like you've made some changes in your pull request, so I've checked the code again for style. There are no PEP8 style issues with this pull request - thanks! 🎉 Comment last updated at 2022-09-08 20:54:12 UTC |
|
Hi humans 👋 - this pull request hasn't had any new commits for approximately 4 months. I plan to close this in 30 days if the pull request doesn't have any new commits by then. In lieu of a stalled pull request, please consider closing this and open an issue instead if a reminder is needed to revisit in the future. Maintainers may also choose to add keep-open label to keep this PR open but it is discouraged unless absolutely necessary. If this PR still needs to be reviewed, as an author, you can rebase it to reset the clock. If you believe I commented on this pull request incorrectly, please report this here. |
|
I think this is worth pursusing - I don't have time to figure out how to update fiugre tests in astropy at the moment, but if someone else has the motivation to feel free to push to my branch or create a new branch+PR off this branch. |
|
I will need to rebase once #12630 is merged to get the latest infrastructure changes |
|
Hmm... Did you break the autobackport bot? lol @meeseeksdev backport to v5.0.x @meeseeksdev backport to v5.1.x |
…418-on-v5.1.x Backport PR #12418 on branch v5.1.x (Fix tight_layout for WCSAxes)
…418-on-v5.0.x Backport PR #12418 on branch v5.0.x (Fix tight_layout for WCSAxes)
|
Thanks a lot @astrofrog for finishing off my PRs! |
Without doing a major refactoring of WCSAxes to make things work more like they do in Matplotlib, this fixes #8703