Skip to content

TST: Pin maxversion of pytest-astropy-header - #12643

Merged
mhvk merged 1 commit into
astropy:mainfrom
pllim:tst-pin-header
Dec 27, 2021
Merged

mhvk merged 1 commit into
astropy:mainfrom
pllim:tst-pin-header

Conversation

@pllim

@pllim pllim commented Dec 27, 2021 •

Copy link
Copy Markdown
Member

Description

This pull request is to temporarily pin max version of pytest-astropy-header until we can figure out #12642 . If my suspicion is true, CI should pass again with this pin.

Also see astropy/pytest-astropy-header#41

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see "When to rebase and squash commits".
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the Extra CI label.
  • Is a change log needed? If yes, did the change log check pass? If no, add the no-changelog-entry-needed label. If this is a manual backport, use the skip-changelog-checks label unless special changelog handling is necessary.
  • Is a milestone set? Milestone must be set but astropy-bot check might be missing; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate backport-X.Y.x label(s) before merge.

@github-actions

Copy link
Copy Markdown
Contributor

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

@mhvk mhvk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like your suspicion is indeed true... Weird! But let's get this in so that the tests run properly again.

@mhvk
mhvk merged commit dc2d514 into astropy:main Dec 27, 2021
meeseeksmachine pushed a commit to meeseeksmachine/astropy that referenced this pull request Dec 27, 2021
@pllim
pllim deleted the tst-pin-header branch December 28, 2021 00:19
pllim added a commit that referenced this pull request Dec 28, 2021
…643-on-v5.0.x

Backport PR #12643 on branch v5.0.x (TST: Pin maxversion of pytest-astropy-header)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants