Repository navigation
Fix write and read FITS tables without ColDefs structure - #12863
Merged
Merged
Conversation
Contributor
|
Thanks @cmarmo! I'm not sure to really understand the change but it seems to work so fine by me :). Could you add a changelog entry ? |
Member
Author
|
I have added a changelog and modified some comments: I hope this will help in clarifying what I believe was the issue. |
meeseeksmachine
pushed a commit
to meeseeksmachine/astropy
that referenced
this pull request
Mar 24, 2022
…lDefs` structure
saimn
added a commit
that referenced
this pull request
Mar 24, 2022
…863-on-v5.0.x Backport PR #12863 on branch v5.0.x (Fix write and read FITS tables without `ColDefs` structure)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request is to address the issues described in #5280 and #5287.
It improve the conversion of table columns from record format spec to FITS format spec in the case of multidimensional objects.
Fixes #5280, fixes #5287.
Thank you for considering it.
Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
Extra CIlabel.no-changelog-entry-neededlabel. If this is a manual backport, use theskip-changelog-checkslabel unless special changelog handling is necessary.astropy-botcheck might be missing; do not let the green checkmark fool you.backport-X.Y.xlabel(s) before merge.