Skip to content

Backport PR #14784 on branch v5.3.x (TST: Test against Python 3.12 pre-prelease) - #15370

Merged
pllim merged 3 commits into
astropy:v5.3.xfrom
pllim:backport-of-pr-14784-on-v5.3.x
Sep 22, 2023
Merged

pllim merged 3 commits into
astropy:v5.3.xfrom
pllim:backport-of-pr-14784-on-v5.3.x

Conversation

@pllim

@pllim pllim commented Sep 21, 2023 •

Copy link
Copy Markdown
Member

Description

This pull request is to manually backport:

Blocked by:

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@pllim pllim added Manual Backport skip-changelog-checks Tells bot to skip changlog checks skip-basebranch-check Skip base branch check for direct backports Python 3.12 labels Sep 21, 2023
@pllim pllim added this to the v5.3.4 milestone Sep 21, 2023
@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see "When to rebase and squash commits".
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • Is a milestone set? Milestone must be set but we cannot check for it on Actions; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@github-actions

Copy link
Copy Markdown
Contributor

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

@pllim pllim added Extra CI Run cron CI as part of PR Build all wheels Run all the wheel builds rather than just a selection labels Sep 21, 2023
@pllim
pllim force-pushed the backport-of-pr-14784-on-v5.3.x branch from b7055c9 to a7ec00c Compare September 22, 2023 00:55
@pllim
pllim force-pushed the backport-of-pr-14784-on-v5.3.x branch from a7ec00c to 9d85960 Compare September 22, 2023 01:06
@pllim

pllim commented Sep 22, 2023

Copy link
Copy Markdown
Member Author

"Exotic archs" failures are unrelated (#15351).

but that is irrelevant for v5.3.x so we just stop cross-ref.
@pllim
pllim marked this pull request as ready for review September 22, 2023 13:40
@pllim
pllim requested a review from taldcroft as a code owner September 22, 2023 13:40
@pllim

pllim commented Sep 22, 2023

Copy link
Copy Markdown
Member Author

Just a manual backport of approved materials, so merging.

@pllim
pllim merged commit e91d9af into astropy:v5.3.x Sep 22, 2023
@pllim
pllim deleted the backport-of-pr-14784-on-v5.3.x branch September 22, 2023 13:41
pllim added a commit that referenced this pull request Sep 22, 2023
because it does not exist anymore after #15247 .

This is similar to that patch in #15370 for v5.3.x
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Build all wheels Run all the wheel builds rather than just a selection Extra CI Run cron CI as part of PR installation Manual Backport nddata Python 3.12 skip-basebranch-check Skip base branch check for direct backports skip-changelog-checks Tells bot to skip changlog checks table testing time

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant