Repository navigation
MNT: Run PTH flake test in prep for supporting pathlib (convolution) - #16918
Merged
Merged
Conversation
Contributor
|
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
Contributor
|
👋 Thank you for your draft pull request! Do you know that you can use |
neutrinoceros
force-pushed
the
convolution/rfc/pth_checks
branch
from
September 3, 2024 08:11
bec629c to
1597c57
Compare
neutrinoceros
force-pushed
the
convolution/rfc/pth_checks
branch
from
September 3, 2024 15:51
1597c57 to
2071647
Compare
Co-authored-by: Mridul Seth <[email protected]>
neutrinoceros
force-pushed
the
convolution/rfc/pth_checks
branch
from
September 3, 2024 16:42
2071647 to
343fafd
Compare
neutrinoceros
marked this pull request as ready for review
September 3, 2024 16:53
neutrinoceros
requested review from
WilliamJamieson,
larrybradley and
nstarman
as code owners
September 3, 2024 16:53
Contributor
Author
|
Note that labels |
pllim
approved these changes
Sep 3, 2024
pllim
left a comment
Member
There was a problem hiding this comment.
LGTM. Thanks!
I think as long as Windows job passes, we should be ok. You never know with Windows sometimes.
Member
|
Actually, let's run pyinstaller too. Just in case... |
This was referenced Jun 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Extracted from #16060
based off #16917 (only the last commit is exclusive to this branch)@larrybradley already approved this bit in #16060 (review)