Skip to content

Remove hardcoded arrays in test_models.py and test_bls.py - #18353

Merged
pllim merged 2 commits into
astropy:mainfrom
astrofrog:remove-hardcoded-arrays
Jun 30, 2025
Merged

pllim merged 2 commits into
astropy:mainfrom
astrofrog:remove-hardcoded-arrays

Conversation

@astrofrog

Copy link
Copy Markdown
Member

Description

A net removal of 1535 lines! 😆

Fixes #11567

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@astrofrog
astrofrog requested a review from pllim June 26, 2025 10:38

@pllim pllim left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clean-up!

Since you are also the timeseries maintainer, I will just have to trust you that you have checked the new test results are okay.

@pllim
pllim merged commit 2b8a6f6 into astropy:main Jun 30, 2025
meeseeksmachine pushed a commit to meeseeksmachine/astropy that referenced this pull request Jun 30, 2025
pllim added a commit that referenced this pull request Jun 30, 2025
…353-on-v7.1.x

Backport PR #18353 on branch v7.1.x (Remove hardcoded arrays in ``test_models.py`` and ``test_bls.py``)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TST: Revert hardcoding in test_bls.py and test_models.py

2 participants