Repository navigation
FIX: Issue 15397 - #18424
FIX: Issue 15397#18424
Conversation
|
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
There was a problem hiding this comment.
Welcome to Astropy 👋 and congratulations on your first pull request! 🎉
A project member will respond to you as soon as possible; in the meantime, please have a look over the Checklist for Contributed Code and make sure you've addressed as many of the questions there as possible.
If you feel that this pull request has not been responded to in a timely manner, please send a message directly to the development mailing list. If the issue is urgent or sensitive in nature (e.g., a security vulnerability) please send an e-mail directly to the private e-mail [email protected].
|
👋 Thank you for your draft pull request! Do you know that you can use |
|
@mwcraig in the future please apply backport label before merge. Thanks, all! @meeseeksdev backport to v7.1.x |
…424-on-v7.1.x Backport PR #18424 on branch v7.1.x (FIX: Issue 15397)
Description
The numpy functions np.min, np.max, np.mean, and np.sum did not work due to key errors. Numpy updated to allow for some extra arguments
out, and for mean,dtype. These keys need to be popped off and checked for content. This fix pops the keys if they exist and then checks if they areNone, erroring if the keys are notNone.Fixes #15397