Skip to content

FIX: Issue 15397 - #18424

Merged
mwcraig merged 5 commits into
astropy:mainfrom
Nanoemc:issue_15397
Jul 13, 2025
Merged

mwcraig merged 5 commits into
astropy:mainfrom
Nanoemc:issue_15397

Conversation

@Nanoemc

@Nanoemc Nanoemc commented Jul 13, 2025

Copy link
Copy Markdown
Contributor

Description

The numpy functions np.min, np.max, np.mean, and np.sum did not work due to key errors. Numpy updated to allow for some extra arguments out, and for mean, dtype. These keys need to be popped off and checked for content. This fix pops the keys if they exist and then checks if they are None, erroring if the keys are not None.

Fixes #15397

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@github-actions

github-actions Bot commented Jul 13, 2025 •

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to Astropy 👋 and congratulations on your first pull request! 🎉

A project member will respond to you as soon as possible; in the meantime, please have a look over the Checklist for Contributed Code and make sure you've addressed as many of the questions there as possible.

If you feel that this pull request has not been responded to in a timely manner, please send a message directly to the development mailing list. If the issue is urgent or sensitive in nature (e.g., a security vulnerability) please send an e-mail directly to the private e-mail [email protected].

@github-actions

Copy link
Copy Markdown
Contributor

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

@Nanoemc
Nanoemc marked this pull request as ready for review July 13, 2025 20:58
@Nanoemc
Nanoemc marked this pull request as draft July 13, 2025 20:58
@Nanoemc
Nanoemc marked this pull request as ready for review July 13, 2025 20:59
@Nanoemc

Nanoemc commented Jul 13, 2025

Copy link
Copy Markdown
Contributor Author

@mwcraig Here is the pull request for #15397

@mwcraig mwcraig added this to the v7.1.1 milestone Jul 13, 2025

@mwcraig mwcraig left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Nanoemc -- this turned out to be a big project!

@pllim

pllim commented Jul 14, 2025

Copy link
Copy Markdown
Member

@mwcraig in the future please apply backport label before merge.

Thanks, all!

@meeseeksdev backport to v7.1.x

meeseeksmachine pushed a commit to meeseeksmachine/astropy that referenced this pull request Jul 14, 2025
pllim added a commit that referenced this pull request Jul 14, 2025
…424-on-v7.1.x

Backport PR #18424 on branch v7.1.x (FIX: Issue 15397)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CCDData raises KeyError when passed into numpy functions on numpy 1.24

3 participants