Repository navigation
WHL: build and test wheels against CPython 3.14 (GIL-enabled) (twin #18457) - #18458
Conversation
|
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
|
👋 Thank you for your draft pull request! Do you know that you can use |
e8d0b18 to
9487074
Compare
|
Interesting, there are failures on some platform, but not all, while nothing fails on |
|
Do we really need GIL-enabled Python 3.14 build in v7.1.x? |
|
I don't know, but it seems worth exploring. I'd like whatever our next release is to have 3.14-compatible wheels, and if we can't do that, at least learn why. |
|
v7.2 (or v8.0, depending on how the astropy-dev discussions go) would be out by the end of 2025 (a few months) and then we don't have to worry about v7.1.x anymore, right? If it comes "for free," sure, but red CI here suggests otherwise. |
|
Actually it seems to me that the one failure we're seeing shows that #18139 wasn't actually included in 7.1.0 (as the milestone would suggest), but since it's a bug fix, we might as well just backport it now. I'll try this here to confirm that the approach is sound, and if so, I'll give it its own backport PR. |
|
Looking good, here's the dedicated backport #18461 |
|
I don't understand. The backport PR (#18156) was merged. |
|
oh, weird. The auto-backported only included 1 in 3 commits. My manual backport has the other 2. |
Description
This is the same as #18457, but targetting the backport branch, since this patch doesn't auto-backport cleanly.