Skip to content

Ignore the endianess markers in Numpy dtype strings - #1855

Merged
mdboom merged 1 commit into
astropy:masterfrom
mdboom:testing/ignore-endianness
Dec 3, 2013
Merged

mdboom merged 1 commit into
astropy:masterfrom
mdboom:testing/ignore-endianness

Conversation

@mdboom

@mdboom mdboom commented Dec 2, 2013

Copy link
Copy Markdown
Contributor

Partial fix for #1849.

@mdboom

mdboom commented Dec 2, 2013

Copy link
Copy Markdown
Contributor Author

Doesn't need changelog entry. This fixes a bug in an unreleased feature (doctest testing).

@mdboom

mdboom commented Dec 3, 2013

Copy link
Copy Markdown
Contributor Author

@olebole: Are you able to test this branch on the big endian platforms, or should I just merge and let it propagate out and cross our fingers?

@olebole

olebole commented Dec 3, 2013

Copy link
Copy Markdown
Member

I could test it (in the context of a package build), but the patch does not apply to 0.3.0.?

@mdboom

mdboom commented Dec 3, 2013

Copy link
Copy Markdown
Contributor Author

That's true -- the doctesting was significantly reworked post 0.3.0... It will take some work to get this on 0.3.0, or we can just wait until 0.3.1, I guess.

@olebole

olebole commented Dec 3, 2013

Copy link
Copy Markdown
Member

I have no problem to help by just crossing fingers and uploading 0.3.1 ;-)
Is there a plan to release it soon?

@mdboom

mdboom commented Dec 3, 2013

Copy link
Copy Markdown
Contributor Author

I don't think we have any 0.3.1 plans at the moment, but I'm sure there will be one...

@mdboom

mdboom commented Dec 3, 2013

Copy link
Copy Markdown
Contributor Author

I'm going to merge this, as I think it's mostly harmless on little endian machines and might fix things on big endian machines.

mdboom added a commit that referenced this pull request Dec 3, 2013
Ignore the endianess markers in Numpy dtype strings
@mdboom
mdboom merged commit 2c9c6f6 into astropy:master Dec 3, 2013
mdboom added a commit that referenced this pull request Feb 12, 2014
Ignore the endianess markers in Numpy dtype strings
mdboom added a commit that referenced this pull request Feb 12, 2014
Ignore the endianess markers in Numpy dtype strings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants