Skip to content

Constants - #20

Closed
astrofrog wants to merge 26 commits into
astropy:masterfrom
astrofrog:constants
Closed

Constants#20
astrofrog wants to merge 26 commits into
astropy:masterfrom
astrofrog:constants

Conversation

@astrofrog

@astrofrog astrofrog commented Oct 15, 2011

Copy link
Copy Markdown
Member

Note: this module is not ready for merging. I am opening this pull request so that we can review the current code and iterate on it first (with the ultimate goal of merging).

A few notes:

  • I decided to always use _ for subscripts and to use lowercase and uppercase as is usually conventional - but we can also switch to all lowercase if you think that would be best
  • I decided to spell out sun, jup, and earth to avoid a possible conflict between electron mass and earth mass (let me know if you have a better idea!).
  • The S.I. constants re-use the values from the cgs module so that we only need to change constants in one place.
  • There are no tests yet, as I'm not sure what tests would consist of in the case of constants. Maybe we can check for example that a certain dimensionless combination of constants in cgs is equal to that in S.I. (which would test the c.g.s to S.I conversion).
  • I need to double check the constants values, and we'll need several other people to vet them, since this is obviously very important to get right.

taldcroft and others added 26 commits October 15, 2011 12:45
@taldcroft @astrofrog
Add OrderedDict class via utils/odict.py for Python 2.6 usage.
3c5fef6
@astrofrog
Removed unused code in odict and ensure that it runs correctly with p…
821dbcd 
…y.test-2.7
@astrofrog
Removed ability to get views from OrderedDict (not a Python 2.6 featu…
a357b19 
…re, and requires additional code that is currently missing).
@astrofrog
Removed unused import statements
6b7b1c7
@astrofrog
Use built-in OrderedDict for Python 2.7 and above
581a07d
@astrofrog
Avoid using BackportedOrderedDict, since this causes issues with test…
8c9cad4 
…ing under Python 2.6
@astrofrog
Fix tests to work in Python 2.6
573f2b3
@astrofrog
Import OrderedDict into astropy.utils
2e1f3b0
@mdboom @astrofrog
Add a basic building and package guide based on the discussion had at…
9da8330 
… AstroPy Meeting Oct 13, 2011.
@jiffyclub @astrofrog
Adding the py.test --genscript standalone script to astropy/extern/py…
3309fa2 
…test.py.
@jiffyclub @astrofrog
Moved tests directory from the root level to astropy/tests and remove…
0cad80a 
…d the README.rst file from the tests directory.
@jiffyclub @astrofrog
Updated docs/overview.rst with description of astropy/tests.
bc6d83e
@jiffyclub @astrofrog
Added __init__.py to astropy/tests.
3ff0b1c
@jiffyclub @astrofrog
Added astropy/tests/helper.py, which can be used to invoke the pytest…
c5e7b2b 
… module installed with astropy in the event that a user wants to run tests and does not have py.test installed on their system.
@jiffyclub @astrofrog
Added runtests function to astropy/tests/helper.py for running specif…
1081c57 
…ic tests. Will be imported in astropy/__init__.py as test.
@jiffyclub @astrofrog
Added import to astropy/__init__.py so that it has a 'test' function …
68c9f29 
…available. Modified the astropy/tests/helper.py runtests function so that it runs tests in the astropy installed location.
@jiffyclub @astrofrog
Fixed use of module_path instead of module in astropy/tests/helper.py…
f5c8631 
… runtests function.
@jiffyclub @astrofrog
Changed astropy/tests/helper.py imports to relative imports.
5e45d94
@jiffyclub @astrofrog
Changed runtests to run_tests.
a605270
@jiffyclub @astrofrog
Updated astropy/__init__.py to an explicit relative import.
3350e17
@eteq @astrofrog
added BSD 3-clause license
e34135a
@astrofrog
Added options to astropy.test() for passing to py.test (including arb…
b68cd9f 
…itrary arguments, plugins, and more specific verbose and pastebin options)
@astrofrog
Make pastebin=True default to pastebin=failed
85c0416
@astrofrog
Changed an Exception to ValueError
a7ce6c6
@astrofrog
Initial commit of cgs and S.I. constants
73d3d70
@astrofrog
Minor fixes to S.I. conversion
364d3a9
@astrofrog

astrofrog commented Oct 15, 2011

Copy link
Copy Markdown
Member Author

Closed because of a mistake in the commits included

@astrofrog astrofrog closed this Oct 15, 2011
astrofrog added a commit that referenced this pull request Dec 14, 2012
@astrofrog
Merge pull request #20 from mdboom/votable/table-interface
78f2a98 
Follow on to #524
keflavich pushed a commit to keflavich/astropy that referenced this pull request Oct 9, 2013
@astrofrog
Merge pull request astropy#20 from mdboom/votable/table-interface
39b2452 
Follow on to astropy#524
mdboom added a commit that referenced this pull request Apr 23, 2014
@mdboom
Merge pull request #20 from embray/misc/clang-analyzer
05d89b1 
Some slight tweaks to how I wanted to handle cleanup in the compress_hdu...
taldcroft pushed a commit to taldcroft/astropy that referenced this pull request Apr 29, 2014
@eteq
Merge pull request astropy#20 from eteq/coordinates-ape5-defaultfattrs
014e500 
Method to check if attributes were set explicitly
@mdboom mdboom mentioned this pull request Apr 17, 2015
Closed
nden pushed a commit to nden/astropy that referenced this pull request Dec 10, 2018
@Cadair
Merge pull request astropy#20 from nden/serialize-equivalencies
9e28227 
serialize equivalencies
jeffjennings pushed a commit to jeffjennings/astropy that referenced this pull request Jul 2, 2025
@eteq
Merge pull request astropy#20 from hamogu/patch-1
6479a15 
remove double word in affilited/intex.html
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@astrofrog @taldcroft @mdboom @jiffyclub @eteq