Skip to content

Fixing failing tests in test_automodapi - #2430

Merged
astrofrog merged 1 commit into
astropy:masterfrom
bsipocz:fixing_failing_automodapi_test
May 4, 2014
Merged

astrofrog merged 1 commit into
astropy:masterfrom
bsipocz:fixing_failing_automodapi_test

Conversation

@bsipocz

@bsipocz bsipocz commented May 4, 2014

Copy link
Copy Markdown
Member

This PR fixes test in test_automodapi which were failing after the recent changes in automodapi (#2370).

@astrofrog

Copy link
Copy Markdown
Member

Tested locally and fixes the tests - thanks @bsipocz!

@astrofrog astrofrog closed this May 4, 2014
@astrofrog astrofrog reopened this May 4, 2014
astrofrog added a commit that referenced this pull request May 4, 2014
@astrofrog
astrofrog merged commit ec3c8c5 into astropy:master May 4, 2014
@bsipocz

bsipocz commented May 4, 2014

Copy link
Copy Markdown
Member Author

@astrofrog - Opps, in the same time of the merge, I pushed another commit with fixing the doctest failure in astropy.table mentioned in the same issue. Should I open another PR or can you merge it again?

@bsipocz

bsipocz commented May 4, 2014

Copy link
Copy Markdown
Member Author

Well, it appears that I could only push the commit to my branch, but not to this PR. So the other small fix is in #2431

@embray

embray commented May 5, 2014

Copy link
Copy Markdown
Member

Thanks for fixing this--it was really annoying me 😄

@bsipocz

bsipocz commented May 5, 2014

Copy link
Copy Markdown
Member Author

My pleasure 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants