Skip to content

Move pywcs' old CHANGELOG into astropy as history.rst - #25

Merged
eteq merged 4 commits into
astropy:masterfrom
mdboom:pywcs
Oct 19, 2011
Merged

eteq merged 4 commits into
astropy:masterfrom
mdboom:pywcs

Conversation

@mdboom

@mdboom mdboom commented Oct 18, 2011

Copy link
Copy Markdown
Contributor

No description provided.

@astrofrog

Copy link
Copy Markdown
Member

Looks good to me.

@eteq

eteq commented Oct 19, 2011

Copy link
Copy Markdown
Member

Looks fine to me... except that I'm now seeing this error when I build the docs

[u'Wcsprm.dateavg', u':module: astropy.wcs', u'', u'``string``', u'', u'Representative mid-point of the date of observation in ISO format,', u'``yyyy-mm-ddThh:mm:ss``.', u'', u'.. seealso::', u'', u'   `~astropy.wcs.Wcsprm.dateobs`', u'``string``', u'', u'Start of the date of observation in ISO format,', u'``yyyy-mm-ddThh:mm:ss``.', u'', u'.. seealso::', u'', u'   `~astropy.wcs.Wcsprm.dateavg`']:11: (WARNING/2) Explicit markup ends without a blank line; unexpected unindent.

I'm a bit mystified at what made this appear, because I built the docs without any problems after the last pull request (I thought...), and this doesn't seem to have any history-related part. I think this is complaining about there not being a newlline between the first seealso and the next ''string''. But you may as well fix this while you're at it.

@mdboom

mdboom commented Oct 19, 2011

Copy link
Copy Markdown
Contributor Author

I'm not seeing this with current master (1a758b1). I'm on Sphinx 1.0.1, docutils 0.7, numpydoc 1.6.1.

This does point out to me, however, that this still using the Sphinx/docutils ".. seealso::" rather than numpydoc's "See also". I'll make those changes and add to this pull request.

@astrofrog

Copy link
Copy Markdown
Member

I'm using Sphinx 1.1 and I'm not seeing any errors.

@astrofrog

Copy link
Copy Markdown
Member

This is not really a big issue, but at the moment the word cd in the history page links to the Python standard library docs, due to the intersphinx extension. Is there a way to avoid this? (just curious as we'll probably encounter this issue elsewhere too)

@mdboom

mdboom commented Oct 19, 2011

Copy link
Copy Markdown
Contributor Author

I think we'll have to fully qualify these using the ~astropy.wcs.Wcsprm.cd syntax. I'll try to find and replace these.

@astrofrog

Copy link
Copy Markdown
Member

Looks good!

@eteq

eteq commented Oct 19, 2011

Copy link
Copy Markdown
Member

switching to the numpydoc style See Also section fixed the error, so regardless, all is now good.

eteq added a commit that referenced this pull request Oct 19, 2011
Move pywcs' old CHANGELOG into astropy as history.rst
@eteq
eteq merged commit 4ca0211 into astropy:master Oct 19, 2011
astrofrog added a commit that referenced this pull request Apr 20, 2013
Use splitlines instead of split('\n') where appropriate
keflavich pushed a commit to keflavich/astropy that referenced this pull request Oct 9, 2013
Move pywcs' old CHANGELOG into astropy as history.rst
taldcroft pushed a commit to taldcroft/astropy that referenced this pull request May 8, 2014
embray pushed a commit to embray/astropy that referenced this pull request Jan 23, 2015
pllim pushed a commit that referenced this pull request May 25, 2019
Add additional regression test ensuring that we can accept float32 in _erfa

This also tests it at the higher level, in a representation.
mhvk pushed a commit that referenced this pull request Oct 4, 2024
jeffjennings pushed a commit to jeffjennings/astropy that referenced this pull request Jul 2, 2025
add sncosmo to affiliated packages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants