Repository navigation
With quantity output, ensure non-quantity input is treated as dimensionless - #2571
Merged
mdboom merged 1 commit intoJun 13, 2014
Merged
Conversation
Contributor
Author
|
p.s. Second commit is for non-trig functions. Hopefully also gets rid of what seems random travis fail. |
Contributor
|
👍 (Travis failure seems unrelated). |
Contributor
Author
|
travis failure seems unrelated again, though it complains about a missing config file, perhaps just needs #2565? |
Contributor
Author
|
@mdboom - would you like to take a last look? I think this is OK to go in. |
Member
|
This seems fine to me. @mdboom - can you confirm that it looks good to you, and we can merge this in for 0.4? |
Contributor
|
Looks fine to me. Merging. |
mdboom
added a commit
that referenced
this pull request
Jun 13, 2014
…input With quantity output, ensure non-quantity input is treated as dimensionless
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With current master, output from a
ufuncto a quantity works for two argument functions, but not for one-argument ones (see below). This PR fixes this, even though it will rarely be used.