Skip to content

Fix #2418: Fix crash in smart resolver when the resolution doesn't work. - #2591

Merged
astrofrog merged 1 commit into
astropy:masterfrom
mdboom:docs/smart-resolver-fix-crash
Jun 4, 2014
Merged

astrofrog merged 1 commit into
astropy:masterfrom
mdboom:docs/smart-resolver-fix-crash

Conversation

@mdboom

@mdboom mdboom commented Jun 3, 2014

Copy link
Copy Markdown
Contributor

No description provided.

@Cadair

Cadair commented Jun 3, 2014

Copy link
Copy Markdown
Member

easy when you know how eh?

@astrofrog

Copy link
Copy Markdown
Member

Ok, this is a case where we should indeed fix it in the core for affiliated packages that don't yet use astropy-helpers.

@Cadair

Cadair commented Jun 3, 2014

Copy link
Copy Markdown
Member

This removes the error for me, but I am still getting doc warnings that I was not getting on 0.3.2.

@astrofrog

Copy link
Copy Markdown
Member

What kind of warnings are you seeing?

@Cadair

Cadair commented Jun 3, 2014

Copy link
Copy Markdown
Member

Didn't find warnings:

http://paste.yt-project.org/show/4720/

@astrofrog

Copy link
Copy Markdown
Member

I am merging this PR, so @Cadair - feel free to open a new issue if you think the warnings are due to an astropy bug.

astrofrog added a commit that referenced this pull request Jun 4, 2014
Fix #2418: Fix crash in smart resolver when the resolution doesn't work.
@astrofrog
astrofrog merged commit fb73e67 into astropy:master Jun 4, 2014
astrofrog added a commit that referenced this pull request Jun 4, 2014
@Cadair

Cadair commented Jun 4, 2014

Copy link
Copy Markdown
Member

I will check them out,

@mdboom
mdboom deleted the docs/smart-resolver-fix-crash branch March 3, 2015 16:19
astrofrog added a commit to astropy/sphinx-automodapi that referenced this pull request Jan 27, 2018
…er-fix-crash

Fix #2418: Fix crash in smart resolver when the resolution doesn't work.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants