Repository navigation
Move table.Row class into its own submodule table/row.py - #2872
Merged
Merged
Conversation
Member
Author
|
Whether or not this fixes #2871 I think it is probably a good idea just to reduce lines in |
Member
|
I agree, I'm all for smaller files :) 👍 |
Contributor
|
Yes, all for it, even if it doesn't resolve #2871 |
Member
|
Also totally fine by me. I think this can go in 0.4.2 since it doesn't change the ability to |
Member
|
As noted over there, this does not entirely resolve #2871 (although now the time module is the culprit instead of table) but this is not a bad idea in its own right. |
taldcroft
added a commit
that referenced
this pull request
Aug 20, 2014
Move table.Row class into its own submodule table/row.py
taldcroft
added a commit
that referenced
this pull request
Sep 18, 2014
Move table.Row class into its own submodule table/row.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Try to fix #2871.
cc: @embray