Repository navigation
Slight improvement to memory usage for guess - #2880
Merged
Merged
Conversation
Member
|
Looks good to me. @taldcroft ? |
Member
|
Looks good to me. |
astrofrog
added a commit
that referenced
this pull request
Sep 6, 2014
Slight improvement to memory usage for guess
astrofrog
added a commit
that referenced
this pull request
Sep 18, 2014
Slight improvement to memory usage for guess
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a reader results in a
Tableobject (that is nonetheless invalid) delete the local reference to thatTableas soon as we don't need it anymore. That will immediately allow memory to be freed up for the next reader(s) to do their parsing.This came up in #2877, and while it does not solve #2877 it will lessen the impact.