Skip to content

Color and logo - #3

Closed
eteq wants to merge 2 commits into
astropy:masterfrom
eteq:color-and-logo
Closed

eteq wants to merge 2 commits into
astropy:masterfrom
eteq:color-and-logo

Conversation

@eteq

@eteq eteq commented Aug 8, 2011

Copy link
Copy Markdown
Member

This pull request does two things: It adjusts the color scheme in the docs from the default to a somewhat different look, and adds in a logo produced by Kyle Barbary.

If you think the color scheme is not good, that can be removed/altered while leaving the logo in place (although the logo color may want to be tweaked if so, as the scheme is matched to the logo.

@astrofrog

Copy link
Copy Markdown
Member

I'm not keen on this particular color scheme. I strongly feel that it's too early to be customizing the 'look' of the project, so I think that we keep one of the default color schemes for now (though sphinxdoc feels a little less 'boring' than default), and I also think we should just keep the placeholder logo (or none at all). There's nothing wrong with this logo, but I think it'll be more fun to organize a little logo and theme competition once the coding is underway to get everyone involved.

@kbarbary

kbarbary commented Aug 9, 2011

Copy link
Copy Markdown
Member

I agree that it would be better to wait for this sort of thing. The logo/theme competition is a good idea. I was actually surprised to see a logo added to the project this early without input. So perhaps removing the logo or making clear that it is a placeholder would be best.

@eteq

eteq commented Aug 10, 2011

Copy link
Copy Markdown
Member Author

Well, I was about to say I wanted to reward Kyle's excellent work on the logo, but if he wants to wait and enter in the competition, than I withdraw that statement :)

But I was actually intending this to be a temporary scheme, anyway, to be updated later (I hadn't thought of a competition, but that's a good idea!). I'm also fine with just dropping this pull request and waiting until later, though, so if you agree, feel free to close this one without merging.

I agree sphinxdoc looks better than default, but I'm a little concerned that if we switch to that we'll just stick with it (it's rather hard to customize)... and it's what everyone seems to use. But I suppose that's not a big deal, so I can just switch to that on master (given that it's a one-line commit), if you like.

@astrofrog

Copy link
Copy Markdown
Member

Since we agree, just to be cautious (since I think that some people involved in this project would not necessarily be happy with not having any input on this) I'm going to close this pull request for now.

@eteq - I don't actually feel strongly about which default theme to choose, so since as you suggest the current one makes it clearer this is temporary, we can just leave it the way it is :)

@astrofrog astrofrog closed this Aug 10, 2011
mdboom referenced this pull request in mdboom/astropy Oct 20, 2011
Handle the encoding of the file contents in the caller.
taldcroft referenced this pull request in taldcroft/astropy Mar 30, 2012
eteq pushed a commit that referenced this pull request Apr 22, 2013
fix for AngularSeparation initializer oddities
taldcroft pushed a commit that referenced this pull request Sep 9, 2013
Change __repr__ to use value instead of vals
embray added a commit that referenced this pull request Oct 25, 2013
taldcroft pushed a commit that referenced this pull request Oct 2, 2015
Merge tests, add format and description of column to test
mhvk pushed a commit that referenced this pull request May 15, 2018
Don't serialize format as it is now managed with the fits code
adrn pushed a commit that referenced this pull request Oct 24, 2019
nstarman referenced this pull request in nstarman/astropy Aug 31, 2020
Signed-off-by: Nathaniel Starkman <[email protected]>
jeffjennings pushed a commit to jeffjennings/astropy that referenced this pull request Jul 2, 2025
Add gammapy to affiliated package registry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants