Add a 'test' command to setup.py by embray · Pull Request #30 · astropy/astropy

embray · 2011-10-21T21:10:05Z

Adds a 'test' command to the setup.py (distribute comes with a test command but it doesn't work with py.test, so this replaces it outright). This also supports all the existing options to astropy.test() such as module and verbose.

With this it's possible to run all the tests with just setup.py test even if astropy hasn't been installed or built yet. If necessary it will first build extension modules and make them importable.

astrofrog · 2011-10-21T21:45:42Z

I thought instances of AstroPy were recently changed to Astropy? @eteq will know better than me.

All I'm aware of is that the name was changed from AstroPy to astropy in the package metadata. Other than that I thought it was still AstroPy...?

I changed all the documentation references to "Astropy", on the theory that the proper name should be the package name (so the first letter is capitalized just because its a name). No one else voiced an opinion on the mailing list, so the path-of-least-resistance is probably to stick with "Astropy" unless someone has a strong opinion on the capitalization.

I remember your e-mail but I don't remember that part of it--I thought it was just about changing the distribution name. In any case, I'm fine with that, and I'll put it back.

astrofrog · 2011-10-21T21:50:31Z

Works for me! Just made a couple of small comments in the source code, but once those are fixed it seems ready to me.

phn · 2011-10-22T04:26:32Z

I was trying to write this myself, and noticed that in the distribute test command, they have a separate block of code to deal with use_2to3 option. Is this of concern to us?

I'll have to take a look at that--does distribute's test command try to run the tests on 2to3'd code? If so, we'll want to support that functionality as well, at least eventually.

phn · 2011-10-22T04:52:53Z

Using Python 3.2, I get the following error:

Traceback (most recent call last):
  File "setup.py", line 71, in <module>
    extensions.extend(package.get_extensions(BUILD))
  File "/home/phn/code/astropy-forks/iguananaut/astropy/wcs/setup_package.py", line 169, in get_extensions
    generate_c_docstrings()
  File "/home/phn/code/astropy-forks/iguananaut/astropy/wcs/setup_package.py", line 96, in generate_c_docstrings
    docstrings[key] = docstrings[key].encode('utf8').lstrip() + '\0'
TypeError: can't concat bytes to str

mdboom · 2011-10-23T20:11:04Z

@phn: I think I introduced this bug. I'll fix it in master (since it really exists there) and maybe @iguananaut can rebase this branch of it?

embray · 2011-10-24T15:47:40Z

This leads me to another question, and I forget whether or not this has been decided and documented anywhere: Are we officially supporting Python 3 currently? My thinking was that we were coding with Python 3 in mind (requiring Python 2.6 and using as many Py3-isms as possible) but not necessarily officially supporting Python 3 yet.

If we are dedicating ourselves to Python 3 support now that's fine too. But I'll want to get astropy up and running with tox (with documentation on how to set that up) in order to facilitate cross-version testing. The only thing that makes this tricky is that tox uses pip to install dependencies when setting up its virtual environments. And numpy currently does not play well with pip (I've submitted patches to both numpy and pip to fix this issue since both are partially to blame, but those patches aren't available in any current release of those projects).

astrofrog · 2011-10-24T16:00:17Z

I think we are going with Python 3.x compatibility now as much as possible (see http://astropy.org/development/codeguide.html#interface-and-dependencies).

embray · 2011-10-24T16:31:05Z

In that case I'll make sure this works on Python 3 before suggesting that it be pulled.

embray · 2011-10-25T18:49:42Z

After giving it a try, this is working fine currently on 3.2 (haven't tried 3.1). That is in part, of course, since none of the current code needs to be 2to3'd. I don't think that will be the case forever (vo.table, pyfits) so there still needs to be a solution for when we get to that point. But at least it works for now.

eteq · 2011-10-26T01:33:17Z

This pull request now conflicts quite a bit from some of the recently merged changes... perhaps you should merge with the new master and then rebase? It's not obvious to me what the best solution for the merge conflicts is...

embray · 2011-10-26T02:06:23Z

Hrm, I haven't pulled from master in a while. I'll give it a look tomorrow.

…ommand but it doesn't work with py.test, so this replaces it outright). This also supports all the existing options to astropy.test() such as module and verbose.

…extension modules had to be built/rebuilt.

embray · 2011-10-26T15:11:09Z

Okay, I rebased this on master--seems good now. Sorry for all the whitespace changes--my editor is configured to strip extra whitespace from blank lines.

astrofrog · 2011-10-26T15:21:10Z

Looks good to me! By the way, you can add ?w=0 to a github URL to hide whitespace diffs:

https://github.com/astropy/astropy/pull/30/files?w=0

Useful!

Add a 'test' command to setup.py

Addition of most sensible ufuncs

Add a 'test' command to setup.py

Fix smart resolver for descriptor classes

More fitsio tests

astrofrog reviewed Oct 21, 2011
View reviewed changes

phn reviewed Oct 22, 2011
View reviewed changes

embray added 4 commits October 26, 2011 11:06

Adds a 'test' command to the setup.py (distribute comes with a test c…

b1968be

…ommand but it doesn't work with py.test, so this replaces it outright). This also supports all the existing options to astropy.test() such as module and verbose.

Run the tests in a separate process--this way they will work even if …

b045977

…extension modules had to be built/rebuilt.

Oops--fixed format string

9a4f71d

AstroPy -> Astropy in docstrings

006abe0

eteq added a commit that referenced this pull request Oct 26, 2011

Merge pull request #30 from iguananaut/setup-test

49a052e

Add a 'test' command to setup.py

eteq merged commit 49a052e into astropy:master Oct 26, 2011

mhvk referenced this pull request in mhvk/astropy Jul 14, 2013

Merge pull request #30 from mhvk/units-refactor-quantity

c348797

Addition of most sensible ufuncs

keflavich pushed a commit to keflavich/astropy that referenced this pull request Oct 9, 2013

Merge pull request astropy#30 from iguananaut/setup-test

75eaf90

Add a 'test' command to setup.py

embray pushed a commit to embray/astropy that referenced this pull request Jan 23, 2015

Merge pull request astropy#30 from mdboom/smart_resolver

40fdee3

Fix smart resolver for descriptor classes

mdboom mentioned this pull request Apr 17, 2015

Intermittent segfaults with ascii loader #3691

Closed

Cadair pushed a commit to Cadair/astropy that referenced this pull request Nov 29, 2022

Merge pull request astropy#30 from Cadair/fitsio_tests_floats

b33a2a5

More fitsio tests

Conversation

embray commented Oct 21, 2011

Uh oh!

astrofrog Oct 21, 2011

Choose a reason for hiding this comment

Uh oh!

embray Oct 22, 2011

Choose a reason for hiding this comment

Uh oh!

eteq Oct 25, 2011

Choose a reason for hiding this comment

Uh oh!

embray Oct 25, 2011

Choose a reason for hiding this comment

Uh oh!

astrofrog commented Oct 21, 2011

Uh oh!

phn Oct 22, 2011

Choose a reason for hiding this comment

Uh oh!

embray Oct 24, 2011

Choose a reason for hiding this comment

Uh oh!

phn commented Oct 22, 2011

Uh oh!

mdboom commented Oct 23, 2011

Uh oh!

embray commented Oct 24, 2011

Uh oh!

astrofrog commented Oct 24, 2011

Uh oh!

embray commented Oct 24, 2011

Uh oh!

embray commented Oct 25, 2011

Uh oh!

eteq commented Oct 26, 2011

Uh oh!

embray commented Oct 26, 2011

Uh oh!

embray commented Oct 26, 2011

Uh oh!

astrofrog commented Oct 26, 2011

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants