Skip to content

Final what's new in 1.0 changes - #3451

Merged
eteq merged 4 commits into
astropy:masterfrom
astrofrog:whatsnew-1.0-python-versions
Feb 9, 2015
Merged

eteq merged 4 commits into
astropy:masterfrom
astrofrog:whatsnew-1.0-python-versions

Conversation

@astrofrog

Copy link
Copy Markdown
Member

One last small change before 1.0rc2

@astrofrog astrofrog added this to the v1.0.0 milestone Feb 6, 2015
@astrofrog astrofrog mentioned this pull request Feb 6, 2015
10 tasks done
@astrofrog astrofrog changed the title Add mention of dropping Python 3.1 and 3.2 and Numpy 1.5 Final what's new in 1.0 changes Feb 6, 2015
@astrofrog

Copy link
Copy Markdown
Member Author

@eteq - how did you derive these values before:

Since v0.3, by the numbers:

819 issues have been closed
511 pull requests have been merged
57 distinct people have contributed code

Do you have a script? Can we add something similar here? Do we include v0.4.1 to v0.4.4 in the numbers?

@eteq

eteq commented Feb 6, 2015

Copy link
Copy Markdown
Member

@astrofrog - Honestly I don't remember. I think I had some hacked together thing to grab the stats from the github API. Something like https://github.com/astropy/astropy-tools/blob/master/gitastropyplots.py but with a check for when exactly it happened.

@embray

embray commented Feb 6, 2015

Copy link
Copy Markdown
Member

Incidentally, I just ran

[embray@bray:astropy]$ python3.2 setup.py test

and got

Traceback (most recent call last):
  File "setup.py", line 45, in <module>
    cmdclassd = register_commands(NAME, VERSION, RELEASE)
  File "/internal/1/root/src/astropy/astropy/astropy_helpers/astropy_helpers/setup_helpers.py", line 297, in register_commands
    add_command_hooks(registered_commands, srcdir=srcdir)
  File "/internal/1/root/src/astropy/astropy/astropy_helpers/astropy_helpers/setup_helpers.py", line 330, in add_command_hooks
    for setuppkg in iter_setup_packages(srcdir, packages):
  File "/internal/1/root/src/astropy/astropy/astropy_helpers/astropy_helpers/setup_helpers.py", line 561, in iter_setup_packages
    name=packagename + '.setup_package')
  File "/internal/1/root/src/astropy/astropy/astropy_helpers/astropy_helpers/utils.py", line 243, in import_file
    loader = import_machinery.SourceFileLoader(name, filename)
AttributeError: 'module' object has no attribute 'SourceFileLoader'

Should astropy-helpers support Python 3.2? I can't remember if there has been a decision on that point or not. If it needs to it could. If it doesn't need to it should still give a nicer error message instead of just blowing up at the first occasion something doesn't work.

Comment thread docs/whatsnew/1.0.rst Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"pacakge"

@astrofrog
astrofrog force-pushed the whatsnew-1.0-python-versions branch from eb29e9b to dce7979 Compare February 7, 2015 09:53
@astrofrog

Copy link
Copy Markdown
Member Author

@embray - I implemented your comments, thanks!

Regarding Python 3.2, I think it's fine to not support it (I thought that by deciding to not support astropy for 3.1 or 3.2 that decision automatically extended to astropy-helpers). Are you thinking that we should raise an error like astropy-helpers is not supported on Python 3.2 instead of the current error?

@astrofrog
astrofrog force-pushed the whatsnew-1.0-python-versions branch from dce7979 to 09ba430 Compare February 7, 2015 09:57
@eteq

eteq commented Feb 9, 2015

Copy link
Copy Markdown
Member

Looks good, so I'm going to go ahead and merge. We can add the number of issues closed section just before release so it has the latest numbers.

A agree no need to support py 3.2 in the helpers if we're not going to support it in astropy (unless some affiliated package specifically needs it, and I can't imagine that's true right now).

eteq added a commit that referenced this pull request Feb 9, 2015
@eteq
eteq merged commit 49e277a into astropy:master Feb 9, 2015
@eteq eteq mentioned this pull request Feb 9, 2015
eteq added a commit that referenced this pull request Feb 9, 2015
@astrofrog
astrofrog deleted the whatsnew-1.0-python-versions branch July 5, 2016 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants