Repository navigation
Time max, min, ptp, sort - #3681
Conversation
b0805f6 to
3a2cf8a
Compare
|
@taldcroft - now also updated the |
|
@taldcroft - could you have a quick look at the travis failures? I think they occur because |
|
OK, found the problem. Because I had not defined an |
4918b86 to
d257cf5
Compare
|
@taldcroft - and also the sequel to the shape-changing is ready for final review... |
|
@taldcroft - ok, rebased. I must have not quite kept track of all the rebasing! |
|
@mhvk - put in a PR on your branch. Otherwise this looks good to me. |
|
@taldcroft - I looked at your and my argmin code and at first couldn't convince myself either was absolutely correct. But then I remembered my original logic, which was that really one wants to do and looking at While looking at this again, however, I felt somewhat uncomfortable with p.s. Included your test additions with a minor fixup to the way the parametrization was set up. |
|
OK, I'm convinced! I should have remembered |
Following on #3224, this adds
argmin,argmax,max,min, andptpmethods toTime. In order to properly propagatelocationand the twodeltaattributes,minandmaxinternally useargminandargmaxto get indices of the location that should be extracted.@taldcroft - as this builds on #3224, you may want to either just look here, or just look at specific commit adding these methods.
EDIT: also added
argsortandsort.