Repository navigation
Magnitude/Decibel/Dex methods update - #3851
Merged
Merged
Conversation
mhvk
force-pushed
the
logquantity-methods-update
branch
from
June 12, 2015 23:19
44133a1 to
abd2c08
Compare
embray
added
Affects-dev
mhvk
force-pushed
the
logquantity-methods-update
branch
from
June 17, 2015 16:38
abd2c08 to
25eb5b0
Compare
Contributor
Author
Contributor
Author
|
@mdboom - yet another one to have a look at -- or would there be someone else? |
Member
|
Now that #3618 is merged is there anything else holding this one up? |
Contributor
|
Looks good to me. |
mdboom
added a commit
that referenced
this pull request
Jul 22, 2015
Magnitude/Decibel/Dex methods update
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ensures a few more methods on logarithmic quantities work (notably,
stdandvar, which are well-defined even if the magnitude has units).p.s. Will rebase once #3618 is merged; only the last commit matters here.