Repository navigation
Fix botched deprecation of class attribute in _ImageBaseHDU - #3982
Merged
Merged
Conversation
…logous to classmethod but for properties); unfortunately this version only allows read-only properties, as noted, but that's all I have need for at the moment anyhow)
…looking for code in Astropy that actually uses it. As it turns out there isn't any at the moment, but I found these stray imports that could be removed
… accidentally left as methods instead of working as class attributes as required by the original attributes)
… that should have been included with astropy#3916 [skip ci]
Member
Author
|
Ah, of course this has Python 2 bugs... :( |
embray
added a commit
that referenced
this pull request
Jul 21, 2015
Fix botched deprecation of class attribute in _ImageBaseHDU
embray
added a commit
to embray/astropy
that referenced
this pull request
Jul 23, 2015
… lazy evaluation of attributes a la lazyproperty
embray
added a commit
to embray/astropy
that referenced
this pull request
Jul 30, 2015
… lazy evaluation of attributes a la lazyproperty
dhomeier
pushed a commit
to dhomeier/astropy
that referenced
this pull request
Aug 11, 2015
… that should have been included with astropy#3916 [skip ci]
dhomeier
pushed a commit
to dhomeier/astropy
that referenced
this pull request
Aug 11, 2015
… lazy evaluation of attributes a la lazyproperty
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Back in #3916 I deprecated a couple of old class attributes
NumCodeandImgCode. However, it seems there is some old code that actually used these attributes (yay for deprecation!) as found by @mcara. However, I screwed up my attempt to deprecate those class attributes, by leaving them as methods. I think I meant to put a@propertyon top of them, but that still wouldn't have worked correctly since they are used at the class level as well.Although this is a bug fix to v1.1.dev only, I've marked this Affects-release since it also includes a potentially useful new
@classpropertydecorator in order to fix this.