Skip to content

Moved compatibility assert_allclose to astropy.tests.compat - #400

Merged
astrofrog merged 2 commits into
astropy:masterfrom
astrofrog:fix-numpy-import
Oct 4, 2012
Merged

Moved compatibility assert_allclose to astropy.tests.compat#400
astrofrog merged 2 commits into
astropy:masterfrom
astrofrog:fix-numpy-import

Conversation

@astrofrog

@astrofrog astrofrog commented Oct 1, 2012

Copy link
Copy Markdown
Member

This is to avoid importing Numpy when running python setup.py egg_info - @mdboom, does this seem ok to you, since you made the original change?

@astrofrog

astrofrog commented Oct 1, 2012

Copy link
Copy Markdown
Member Author

@mdboom - would it be easy for you to set up a Python 2.7 virtual environment on Shining Panda that has no Numpy? At the moment, the astropy-master-egg_info job is passing even though it shouldn't be, probably because the system Python includes Numpy. (I haven't figured out how to access the Shining Panda instance via ssh yet.)

@astrofrog

astrofrog commented Oct 4, 2012

Copy link
Copy Markdown
Member Author

@mdboom - does this PR look good to you? Just wanted to check, since it's the only thing holding back the use of RTD for the affiliated packages.

@mdboom

mdboom commented Oct 4, 2012

Copy link
Copy Markdown
Contributor

Looks good to me. Thanks for the ping -- I missed it earlier.

astrofrog added a commit that referenced this pull request Oct 4, 2012
@astrofrog
Merge pull request #400 from astrofrog/fix-numpy-import
c1e45e4 
Moved compatibility assert_allclose to astropy.tests.compat
@astrofrog
astrofrog merged commit c1e45e4 into astropy:master Oct 4, 2012
@astrofrog

astrofrog commented Oct 4, 2012

Copy link
Copy Markdown
Member Author

@mdboom - thanks! Regarding my question about the virtual environment, could you easily set up a vanilla python virtualenv with no numpy for running the egg_info test? I just noticed another numpy import we accidentally included back.

keflavich pushed a commit to keflavich/astropy that referenced this pull request Oct 9, 2013
@astrofrog
Merge pull request astropy#400 from astrofrog/fix-numpy-import
be09405 
Moved compatibility assert_allclose to astropy.tests.compat
@astrofrog
astrofrog deleted the fix-numpy-import branch July 5, 2016 18:46
astrofrog added a commit to astrofrog/astropy that referenced this pull request Jun 12, 2019
@astrofrog
Merge pull request astropy#400 from bsipocz/testing_python3.7
86f1159 
Adding python3.7 to the CI matrixes to make sure we're compatible
jeffjennings pushed a commit to jeffjennings/astropy that referenced this pull request Jul 2, 2025
@astrofrog
Merge pull request astropy#400 from astrofrog/devops
0f52b44 
Add new DevOps role
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@astrofrog @mdboom