Repository navigation
Replace cosmology inv_efunc internal methods with cython. - #4127
Merged
Merged
Conversation
aconley
commented
Sep 6, 2015
aconley
commented
Contributor
- Follow on to Speed up distance calculations by ~10-20x #3767, mostly finishes slow comoving_distance in astropy.cosmology #3764, replaces Speed up distances with massive neutrinos by 6-7x #3814
- All unit tests pass, and some more added.
- Also done for massive neutrinos.
- Speedup is ~ 2x over non-cython scalar version without massive neutrinos, and 20x in massive nu case. So compared with before this whole optimization thing started with slow comoving_distance in astropy.cosmology #3764, we're about 20-50x faster.
* All unit tests pass, and some more added. * Also done for massive neutrinos. * Speedup is ~ 10-14x over scalar version -- so a good 200x faster than the original code.
aconley
changed the title
Member
There was a problem hiding this comment.
This is definitely helpful to understanding the code better.
Member
|
Nice example of why the coverage calculation as a percentage is silly (no actual lines were added that aren't covered)... @nhmc - since you are the secondary maintainer, I've assigned this to you for a review |
Contributor
|
This looks excellent to me, thanks for the heads up. |
Contributor
Author
|
So, where are we on this? I presume it will wait for 1.2. |
Member
|
@aconley - Actually, I'm just waiting for appveyor to finish (it failed in what I think is a spurious way, so I restarted it a few hours ago), and will merge it when it's done if it passes. (So that would then easily make the 1.1 cut). |
Member
|
Aha, and there it went! Merging now. Thanks @aconley! |
eteq
added a commit
that referenced
this pull request
Sep 24, 2015
Replace cosmology inv_efunc internal methods with cython for speed
ntessore
pushed a commit
to glass-dev/cosmology
that referenced
this pull request
Dec 7, 2020
Replace cosmology inv_efunc internal methods with cython for speed
ntessore
pushed a commit
to glass-dev/cosmology
that referenced
this pull request
Dec 8, 2020
Replace cosmology inv_efunc internal methods with cython for speed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.