Repository navigation
Another fix for #4164 - #4194
Merged
Merged
Conversation
embray
added
testing
Affects-dev
Member
Author
|
OK, confirmed that this fixes the issue on master--both locally and in the CI builds the issue reported in #4164 is worked around. |
Member
|
I still see it on the quasi current master (Astropy version 1.1.dev13549 as it keeps changing very quickly today). The helper is at c1e28c7 |
Member
Author
|
@bsipocz You might be confusing this with a slightly different issue. There is still an issue where the |
Member
|
@embray - Yes, but I still see the super long paths, etc like this: |
Member
Author
|
@bsipocz Okay, sorry for doubting you. It looks like this might still not be fixed on OSX for some reason. I don't know why it would be any different on OSX but apparently it is? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some reason I botched #4178 in that it did not include a version of astropy-helpers that actually addressed #4164 (I was simultaneously testing other, unrelated updates to astropy-helpers, and probably confused myself at some point along the line).
I have no rebased astropy/astropy-helpers#190 on the master branch of astropy-helpers, and this PR points the astropy-helpers submodule to the correct commit so that it includes those fixes.