Repository navigation
Fix reading of Latex tables with \tabular tag in the first line - #4595
Merged
Merged
Conversation
See astropy#4295 for discussion, but this does not fully resolve that issue.
Member
Author
Member
Author
|
All relevant checks passed - the Sphinx failures is in the wcs module and unrelated to the changes here. |
Member
|
I restarted the sphinx build. |
taldcroft
added a commit
that referenced
this pull request
Feb 12, 2016
Fix reading of Latex tables with ``\tabular`` tag in the first line
eteq
pushed a commit
that referenced
this pull request
Feb 24, 2016
Fix reading of Latex tables with ``\tabular`` tag in the first line
eteq
pushed a commit
that referenced
this pull request
Feb 29, 2016
Fix reading of Latex tables with ``\tabular`` tag in the first line
hamogu
added a commit
to hamogu/astropy
that referenced
this pull request
Jan 10, 2025
This commit fixes astropy#4595 as discussed in that issue: It makes the finding of the \begin{tabular} (and similar keywords) a little bit more flexible by allowing extra white space. Extra white space is easy to introduce when copying and pasting from a LaTeX file. It does not implement any further flexibility. It does not allow extra text in front of the tag because the reader cannot replace a full LaTeX parser an we prefer to fail in cases like `1 & 3 & 4 \\ \end{tabular}` instead of silently dropping the last row of data just because it happens to be in the same line as the `\end{tabular}`. It also does not add a reader to read LaTeX tables without the \bgin{tabular} \end{tabular} lines. Every full LaTeX table has those and if users copy and paste from a longer LaTeX file, they can simply include those lines. Documentation has been added to that effect.
1 task
mhvk
pushed a commit
to hamogu/astropy
that referenced
this pull request
Jan 11, 2025
This commit fixes astropy#4595 as discussed in that issue: It makes the finding of the \begin{tabular} (and similar keywords) a little bit more flexible by allowing extra white space. Extra white space is easy to introduce when copying and pasting from a LaTeX file. It does not implement any further flexibility. It does not allow extra text in front of the tag because the reader cannot replace a full LaTeX parser an we prefer to fail in cases like `1 & 3 & 4 \\ \end{tabular}` instead of silently dropping the last row of data just because it happens to be in the same line as the `\end{tabular}`. It also does not add a reader to read LaTeX tables without the \bgin{tabular} \end{tabular} lines. Every full LaTeX table has those and if users copy and paste from a longer LaTeX file, they can simply include those lines. Documentation has been added to that effect.
pllim
pushed a commit
that referenced
this pull request
Jan 11, 2025
…r}` (#17624) * Read LaTeX tables where there is whitespace before the `\begin{tabular}` This commit fixes #4595 as discussed in that issue: It makes the finding of the \begin{tabular} (and similar keywords) a little bit more flexible by allowing extra white space. Extra white space is easy to introduce when copying and pasting from a LaTeX file. It does not implement any further flexibility. It does not allow extra text in front of the tag because the reader cannot replace a full LaTeX parser an we prefer to fail in cases like `1 & 3 & 4 \\ \end{tabular}` instead of silently dropping the last row of data just because it happens to be in the same line as the `\end{tabular}`. It also does not add a reader to read LaTeX tables without the \bgin{tabular} \end{tabular} lines. Every full LaTeX table has those and if users copy and paste from a longer LaTeX file, they can simply include those lines. Documentation has been added to that effect.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #4295 for discussion, but this does not fully resolve that
issue.