Skip to content

Fix reading of Latex tables with \tabular tag in the first line - #4595

Merged
taldcroft merged 1 commit into
astropy:masterfrom
hamogu:latexline0
Feb 12, 2016
Merged

taldcroft merged 1 commit into
astropy:masterfrom
hamogu:latexline0

Conversation

@hamogu

@hamogu hamogu commented Feb 10, 2016

Copy link
Copy Markdown
Member

See #4295 for discussion, but this does not fully resolve that
issue.

See astropy#4295 for discussion, but this does not fully resolve that
issue.
@hamogu

hamogu commented Feb 10, 2016

Copy link
Copy Markdown
Member Author

@taldcroft @AMAN3003

@hamogu

hamogu commented Feb 10, 2016

Copy link
Copy Markdown
Member Author

All relevant checks passed - the Sphinx failures is in the wcs module and unrelated to the changes here.

@taldcroft

Copy link
Copy Markdown
Member

I restarted the sphinx build.

@taldcroft taldcroft added this to the v1.0.9 milestone Feb 12, 2016
@taldcroft taldcroft self-assigned this Feb 12, 2016
taldcroft added a commit that referenced this pull request Feb 12, 2016
Fix reading of Latex tables with ``\tabular`` tag in the first line
@taldcroft
taldcroft merged commit 53ac862 into astropy:master Feb 12, 2016
eteq pushed a commit that referenced this pull request Feb 24, 2016
Fix reading of Latex tables with ``\tabular`` tag in the first line
eteq pushed a commit that referenced this pull request Feb 29, 2016
Fix reading of Latex tables with ``\tabular`` tag in the first line
@hamogu
hamogu deleted the latexline0 branch January 4, 2022 14:29
hamogu added a commit to hamogu/astropy that referenced this pull request Jan 10, 2025
This commit  fixes astropy#4595 as discussed in that issue:
It makes the finding of the \begin{tabular} (and similar keywords) a little bit more flexible by allowing extra white space. Extra white space is easy to introduce when copying and pasting from a LaTeX file. It does not implement any further flexibility. It does not allow extra text in front of the tag because the reader cannot replace a full LaTeX parser an we prefer to fail in cases like `1 & 3 & 4 \\ \end{tabular}` instead of silently dropping the last row of data just because it happens to be in the same line as the `\end{tabular}`.
It also does not add a reader to read LaTeX tables without the \bgin{tabular} \end{tabular} lines. Every full LaTeX table has those and if users copy and paste from a longer LaTeX file, they can simply include those lines. Documentation has been added to that effect.
mhvk pushed a commit to hamogu/astropy that referenced this pull request Jan 11, 2025
This commit  fixes astropy#4595 as discussed in that issue:
It makes the finding of the \begin{tabular} (and similar keywords) a little bit more flexible by allowing extra white space. Extra white space is easy to introduce when copying and pasting from a LaTeX file. It does not implement any further flexibility. It does not allow extra text in front of the tag because the reader cannot replace a full LaTeX parser an we prefer to fail in cases like `1 & 3 & 4 \\ \end{tabular}` instead of silently dropping the last row of data just because it happens to be in the same line as the `\end{tabular}`.
It also does not add a reader to read LaTeX tables without the \bgin{tabular} \end{tabular} lines. Every full LaTeX table has those and if users copy and paste from a longer LaTeX file, they can simply include those lines. Documentation has been added to that effect.
pllim pushed a commit that referenced this pull request Jan 11, 2025
…r}` (#17624)

* Read LaTeX tables where there is whitespace before the `\begin{tabular}`

This commit  fixes #4595 as discussed in that issue:
It makes the finding of the \begin{tabular} (and similar keywords) a little bit more flexible by allowing extra white space. Extra white space is easy to introduce when copying and pasting from a LaTeX file. It does not implement any further flexibility. It does not allow extra text in front of the tag because the reader cannot replace a full LaTeX parser an we prefer to fail in cases like `1 & 3 & 4 \\ \end{tabular}` instead of silently dropping the last row of data just because it happens to be in the same line as the `\end{tabular}`.
It also does not add a reader to read LaTeX tables without the \bgin{tabular} \end{tabular} lines. Every full LaTeX table has those and if users copy and paste from a longer LaTeX file, they can simply include those lines. Documentation has been added to that effect.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants