Repository navigation
Make TFORMx keyword check more flexible - #4653
Conversation
8561187 to
e6e70d5
Compare
|
Clearly @embray knows that better than I do. I was just trying to go through open PRs with green tests that look as if someone with commit rights just forgot to merge them. |
|
At this point, probably not 1.2, but maybe 1.2.x? @astrofrog , what do you think? |
|
This should be included in 1.2.0 if possible, since it's just a bug fix. @olebole - can you add a changelog entry in the 1.2 section? |
The maximal column length for compressed data in cfitsio changed between version 3370 and 3380. This patch replaces the check with a specific length by a general check of the correct syntax of the keywords.
e6e70d5 to
8a4e41c
Compare
|
I added one, however I start to feel a bit confused on when a changelog entry is needed. |
|
@olebole - a general rule of thumb is, if it fixes an issue with previous released versions, then include a changelog entry. For things like fixing typos or adding a couple of sentences in the documentation, we ususally don't do it though. But here it actually fixes a bug that caused a test to fail in certain circumstances, so to me that's worth a changelog entry. |
|
@astrofrog - thanks for merging this! However, I noticed the following issue with this pull request:
Would it be possible to fix this? Thanks! This is an experimental bot being written by @astrofrog - let me know if the message above is incorrect! |
|
@astrofrog is that my fault or did the bot just not recognise the change in CHANGES.rst? |
|
The bot demands the number of this PR, not the issue. |
Make TFORMx keyword check more flexible
| - ``astropy.io.fits`` | ||
|
|
||
| - Made TFORMx keyword check more flexible in test of compressed images to | ||
| enable copatibility of the test with cfitsio 3.380. [#4646] |
There was a problem hiding this comment.
Typically don't put changes to tests in the changelog.
|
@astrobot @astrofrog I think changes that just fix a test in order it to pass (in other words, no actual behavior was changed in any significant way) there shouldn't be a changelog entry. |
|
Maybe there should be a separate category like "Bug-in-test" |
6 participants
The maximal column length for compressed data in cfitsio changed between version 3370 and 3380. This patch replaces the check with a specific length by a general check of the correct syntax of the keywords.
This fixes #4646, if @embray raises the green flag.