Repository navigation
Update equivalencies.py - #4766
Conversation
Multiply instead of divide in the equation for beam area (beam_area = 2.*np.pi*(bmaj*bmin*fwhm_to_sigma**2)), because of the way fwhm_to_sigma is defined with (8*np.log(2))**0.5 already in the denominator. I think this is consistent with the equations shown on this page: https://www.cv.nrao.edu/course/astr534/Interferometers2.html But, you can ignore this if I have made a mistake or wrong assumption.
|
Was #4762. |
|
@adamginsburg , can you please have a look since you authored the affected example in fcd0312 ? Are you the same person as @keflavich? |
|
Yes, and I agree that this change is correct. |
|
Not sure why AppVeyor failed. Looks like a timeout somewhere. UPDATE: I can't find a way to restart that build, unlike Travis CI. |
|
@astrofrog , do you own the AppVeyor account? Do you know how to restart it? |
|
@pllim - Not sure how the access rights are managed in appveyor (and also the login is a mess). If you have it you should also log in with the "Astropy" team, and then you'll see a "new build" and a "rebuild PR" buttons on the right top. The one you need is "rebuild PR". Unlike on travis, individual builds cannot be restarted and it will start a new session anyway. I've restarted it here https://ci.appveyor.com/project/Astropy/astropy/build/1.0.3986 |
|
Thanks, @bsipocz . It still failed, but I don't understand why... |
|
Hmm, I'm pretty sure it's totally unrelated, and this is safe to merge. Alternatively do a rebase and the fail should go away. It seems that the parent commit (8f82be8) failed with the same issue here https://ci.appveyor.com/project/Astropy/astropy/build/1.0.3959, but then the fail disappeared on the next merge. cc @astrofrog, as he may have a better idea. |
|
The failure is indeed unrelated - seems like a temporary issue, I think we can just merge this |
|
Done. Thanks, @adeleplunkett ! |
|
Just came along to see if this issue had already been noted, and super glad to see it's already been addressed and fixed for the next release. Thanks @adeleplunkett and everyone! |
6 participants
Multiply instead of divide in the equation for beam area (
beam_area = 2.*np.pi*(bmaj*bmin*fwhm_to_sigma**2)), because of the wayfwhm_to_sigmais defined with(8*np.log(2))**0.5already in the denominator.I think this is consistent with the equations shown on this page: https://www.cv.nrao.edu/course/astr534/Interferometers2.html But, you can ignore this if I have made a mistake or wrong assumption.