Repository navigation
Fix for "python setup.py --help" - #49
Merged
Merged
Conversation
Contributor
|
Looks good to me. |
Member
There was a problem hiding this comment.
This could also be except (DistutilsError, AttributeError):, but either way...
Member
Author
There was a problem hiding this comment.
yeah, I thought about that, but it seemed clearer to leave a comment explaining the situation in a separate except block.
eteq
added a commit
that referenced
this pull request
Nov 7, 2011
Fixes traceback triggered by "setup.py --help"
keflavich
pushed a commit
to keflavich/astropy
that referenced
this pull request
Oct 9, 2013
Fixes traceback triggered by "setup.py --help"
mwcraig
pushed a commit
to mwcraig/astropy
that referenced
this pull request
Jun 6, 2014
Update conda installer
embray
added a commit
to embray/astropy
that referenced
this pull request
Jan 23, 2015
…-2-1 Update minimum Sphinx version to 1.2.1
Cadair
added a commit
to Cadair/astropy
that referenced
this pull request
Dec 23, 2022
Segfault & memory leak hunting
jeffjennings
pushed a commit
to jeffjennings/astropy
that referenced
this pull request
Jul 2, 2025
Dotastro ack updates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the current version,
python setup.py --helpleads to a traceback, due to setup_helpers triggering a bug (or perhaps feature?) in distutils. This patch gets around it by simply catching the exception distutils throws and continuing on with the astropy script.This is quite simple, but I'm not entirely sure what this function is used for, so @iguananaut may want to glance at it before I merge it.