Repository navigation
Don't catch name resolve errors in test_database_specify - #4925
Merged
Merged
Conversation
Member
|
I think this is out of date. I don't remember adding this (and can't figure out how to use blame to see if I actually did), so, sorry I can't be more help! Maybe @mdboom knows? |
Member
Author
|
OK, in the name of making sure the tests aren't broken in 1.2 I'm going to just merge this to get all the remote data tests working... but if anyone has any idea what was original intent was, feel free to issue a PR restoring it! |
eteq
added a commit
that referenced
this pull request
Jun 3, 2016
Don't catch name resolve errors in test_database_specify
Member
Author
|
backported to v1.2.x in dd56a14 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While investigating some of the
remote-dataerrors (a la #4896), I noticed thattest_database_specifyis doing something weird - it catchesNameResolveErrors and tries to replace them with a local/semi-local version. But theexceptclause doesn't do this correctly and ends up just issuing a different error that has no information about the true error. This PR corrects that by just not catching the error at all.@adrn, can you shed some light on the original intent of this? Is it out-of-date code from before
remote_datawas a thing, maybe? If so, I think this is fine to remove.