Repository navigation
First part of fix to get_sun - #4979
Merged
Merged
Conversation
Merged
Contributor
|
I had a quick look -- these are the changes required to match the inputs for |
astrofrog
pushed a commit
that referenced
this pull request
May 31, 2016
First part of fix to get_sun
astrofrog
pushed a commit
that referenced
this pull request
May 31, 2016
First part of fix to get_sun
Member
|
@eteq - I think this needs a changelog entry |
Member
Author
|
Good catch, @astrofrog - it does indeed need a changelog entry. Added to master in ef8ce90, and 1.2.x in 684f086, and 1.0.x in 64ee110 |
eteq
added a commit
to eteq/astropy
that referenced
this pull request
Jun 3, 2016
…roadcasting tricks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in much more detail in #4952, it turns out there are two slightly different changes that need to be made to
get_sun- one that is clearly a fix, and another which may lead to some behavior change.This issue fixes the first part, and hence should be backported to 1.0.x. The second part will be in #4952, and should only go into 1.2.x.
This should be set to go if the tests pass, as it was already reviewed in #4952 (although @mhvk and/or @StuartLittlefair might want to have a quick look)