Skip to content

Update local ERFA to include 2016-Dec-31 leap second - #5395

Closed
pao wants to merge 3 commits into
astropy:masterfrom
pao:topic/2016-leap
Closed

pao wants to merge 3 commits into
astropy:masterfrom
pao:topic/2016-leap

Conversation

@pao

@pao pao commented Oct 6, 2016

Copy link
Copy Markdown

Following the pattern of #3794. Test written but not actually tested.

@pllim

pllim commented Oct 6, 2016

Copy link
Copy Markdown
Member

Travis is still running but Appveyor already failed. Also this will need a change log once milestone is set.

@pao

pao commented Oct 6, 2016

Copy link
Copy Markdown
Author

@pllim if you have the appropriate Travis permissions you can probably kill the first build from the queue.

@mhvk

mhvk commented Oct 7, 2016

Copy link
Copy Markdown
Contributor

I thought leap seconds were not intended to be added by hand, but rather by updating erfa to match the latest sofa version (which has happened) and then starting to use it (#5234). I still think that would be better, but if it is not happening, we should at least do this. @eteq, could you have a look? If there are instructions on how to do it, maybe pass those on? (Or write them...)

@pao

pao commented Oct 7, 2016

Copy link
Copy Markdown
Author

I'm sure that's the correct approach, but nothing I was going to attempt in a drive-by. Either way, Bulletin C has been out for a few months and the leap is only a few more away, so for those of us using Astropy to do UTC-TAI/GPS conversions (hi!) a stopgap table update is better than missing the event entirely.

@mhvk

mhvk commented Oct 18, 2016

Copy link
Copy Markdown
Contributor

See #5418 for an update to the latest version of erfa, which includes the leap second.

@mhvk

mhvk commented Oct 28, 2016

Copy link
Copy Markdown
Contributor

Closing this, since it is superceded by #5418. Nevertheless, thanks for helping ensure we're covered for the leap second, @pao!

@mhvk mhvk closed this Oct 28, 2016
@pao

pao commented Oct 28, 2016

Copy link
Copy Markdown
Author

Thanks, looking forward to the next release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants