Skip to content

Change [pep8] to [pycodestyle] in setup.cfg - #5710

Merged
mhvk merged 1 commit into
astropy:masterfrom
pllim:pycodestyle-setup
Feb 7, 2017
Merged

mhvk merged 1 commit into
astropy:masterfrom
pllim:pycodestyle-setup

Conversation

@pllim

@pllim pllim commented Jan 17, 2017

Copy link
Copy Markdown
Member

Change [pep8] to [pycodestyle] in setup.cfg to remove the following deprecation warning in Travis CI:

/home/travis/miniconda/envs/test/lib/python3.5/site-packages/pycodestyle.py:2155:
  UserWarning: [pep8] section is deprecated. Use [pycodestyle].

  warnings.warn('[pep8] section is deprecated. Use [pycodestyle].')

@bsipocz

bsipocz commented Jan 17, 2017

Copy link
Copy Markdown
Member

👍 good to see they fixed this inconsistency upstream, this didn't worked for #5107 (btw funny that pycodestyle PRs come in anagrams :) )

@mhvk

mhvk commented Jan 18, 2017

Copy link
Copy Markdown
Contributor

Restarted the failed travis job (vo problems as usual...)

@astrofrog

Copy link
Copy Markdown
Member

@mhvk - which tests are failing exactly? (in the random failures)

@mhvk

mhvk commented Jan 18, 2017

Copy link
Copy Markdown
Contributor

@astrofrog - I'll answer in what I think is the relevant issue: #2064.

@pllim

pllim commented Jan 23, 2017

Copy link
Copy Markdown
Member Author

So, is this okay to merge? It is uncontroversial, right?

@mhvk

mhvk commented Feb 7, 2017

Copy link
Copy Markdown
Contributor

Looking at "ready-for-final-review" PRs, I found this one. It does seem very uncontroversial, so I'll merge.

@mhvk
mhvk merged commit 5d3b710 into astropy:master Feb 7, 2017
@astrobot

astrobot commented Feb 7, 2017

Copy link
Copy Markdown

@mhvk - thanks for merging this! However, I noticed the following issue with this pull request:

  • The milestone has not been set

Would it be possible to fix this? Thanks!

If you believe the above to be incorrect (which I - @astrobot - very much doubt) you can ping @astrofrog

@mhvk mhvk added this to the v2.0.0 milestone Feb 7, 2017
@pllim
pllim deleted the pycodestyle-setup branch February 7, 2017 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants