Change deprecated_renamed_argument to allow hiding the deprecations - #5761

uhm, something is blocking Travis. Is OSX down again? 😢

@MSeifert04 - OSX had serious troubles yesterday, but it should be back and working now.

With a second look, it seem that we lost 4 of the astropy workers somewhere, I don't see any other repo being queued than core but it only runs with one worker. I've reported the issue to travis support.

Travis support is actually pretty good, they confirmed that there was a job number limitation due to the issues yesterday. They've lifted it and now everything should be back to normal.

This looks good to me, though I wonder if it wouldn't be better to replace pending with an argument that states when the warning will start (by default equal to since); maybe effective?

So the plan is to undo this again for v2.0? If so, we need to create an issue about it to remind ourselves.

For this one, perhaps a change log under "API change" for 1.3.1?

With effective we would need only a reminder to remove the clobber support in 2.1...

Yes, please add a changelog entry.

@mhvk I tried something like "effective" but that makes it more complicated because we're already at "2.0.dev". So any tests against master (dev) would still have the same problems, or am I wrong?

@bsipocz I'll add a changelog. And thanks for making travis work again 👍

isn't it OK for the warning to be given in current master? I thought we cared mostly that it is not given in 1.3.1.

So, we undo this in 2.1, not 2.0? Just want to clarify before merging.

Or do we simply backport without merging to master? 🤔

Well, we need to use clobber for anything that support the LTS 1.0.x. Once 2.0 is out it become LTS, then can change to use overwrite.
So the deprecation warning can come into play either in 2.0.1 or 2.1 I think. (Or of course it can appear in 2.0, but the it has to be changed last minute so won't screw up the tests against the development version).

So my understanding is to merge this asap (it will fix the dev version testings), and release in 1.3.1 (that would fix the stable testings). Open an issue or even better a PR for adding the warning. That PR must have the flag last-before-release.

If we go with my suggestions earlier, I think we want to start warning users in 2.0 and remove clobber in 2.1.

I added the changelog. Anything else that needs to be done now?

One point to remember: I assumed there will be no astropy 2.1 - the next (not-bugfix-)version after 2.0 is 3.0!

@MSeifert04 - yes, that's right, 2.1 above is 3.0

Okay, I opened #5773 and #5774 as follow-up issues so we don't forget.

LGTM 👍

Thanks, @MSeifert04 !