Skip to content

Redo: split pytest plugins into individual modules - #6384

Merged
astrofrog merged 3 commits into
astropy:masterfrom
drdavella:pytest-plugins
Jul 25, 2017
Merged

astrofrog merged 3 commits into
astropy:masterfrom
drdavella:pytest-plugins

Conversation

@drdavella

Copy link
Copy Markdown
Contributor

I took @Cadair's work from #5770 and rebased it on the current master. The tests pass for me locally in both Python 2.7 and 3.6, but maybe integration testing will reveal some issues that I missed. It might be good to consider this WIP for the moment.

@astropy-bot

astropy-bot Bot commented Jul 21, 2017 •

Copy link
Copy Markdown

Hi there @drdavella 👋 - thanks for the pull request! I'm just a friendly 🤖 that checks for issues related to the changelog and making sure that this pull request is milestoned and labelled correctly. This is mainly intended for the maintainers, so if you are not a maintainer you can ignore this, and a maintainer will let you know if any action is required on your part 😃.

Everything looks good from my point of view! 👍

@drdavella

Copy link
Copy Markdown
Contributor Author

I think @pllim and @bsipocz are already aware, but for selfish reasons I would eventually like to see the testing module split out into a separate package.

@bsipocz

bsipocz commented Jul 21, 2017

Copy link
Copy Markdown
Member

Splittig out the test was the plan with #5770 and the gsoc project idea, so definitely a 👍 from me.

@astrofrog
astrofrog requested a review from Cadair July 21, 2017 15:25
@Cadair

Cadair commented Jul 21, 2017

Copy link
Copy Markdown
Member

Thanks for picking this up @drdavella !

@Cadair Cadair left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm there again, most of it is my commits ;)

@drdavella why does this pass but my original one didn't?!

@astrofrog

Copy link
Copy Markdown
Member

Note that the flake8 failure is real:

astropy/tests/pytest_doctestplus.py:341:1: W391 blank line at end of file

@bsipocz

bsipocz commented Jul 21, 2017

Copy link
Copy Markdown
Member

@Cadair - you've never rebased it. We since removed np1.7, the coverage test failure seems to be passing in fact, and the third one might have been fixed by the removal of the bundled pytest version...

@Cadair

Cadair commented Jul 21, 2017

Copy link
Copy Markdown
Member

ah bundled pytest. I am going to go ahead with the self-reinforcing belief that that was what it was ;)

@drdavella

Copy link
Copy Markdown
Contributor Author

I don't think this PR needs to be considered WIP anymore.

@astrofrog
astrofrog merged commit 84923c0 into astropy:master Jul 25, 2017
@astrofrog

Copy link
Copy Markdown
Member

Thanks @drdavella and @Cadair!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants