Repository navigation
Redo: split pytest plugins into individual modules - #6384
Conversation
|
Hi there @drdavella 👋 - thanks for the pull request! I'm just a friendly 🤖 that checks for issues related to the changelog and making sure that this pull request is milestoned and labelled correctly. This is mainly intended for the maintainers, so if you are not a maintainer you can ignore this, and a maintainer will let you know if any action is required on your part 😃. Everything looks good from my point of view! 👍 |
|
Splittig out the test was the plan with #5770 and the gsoc project idea, so definitely a 👍 from me. |
|
Thanks for picking this up @drdavella ! |
Cadair
left a comment
There was a problem hiding this comment.
lgtm there again, most of it is my commits ;)
@drdavella why does this pass but my original one didn't?!
|
Note that the flake8 failure is real: |
|
@Cadair - you've never rebased it. We since removed np1.7, the coverage test failure seems to be passing in fact, and the third one might have been fixed by the removal of the bundled pytest version... |
|
ah bundled pytest. I am going to go ahead with the self-reinforcing belief that that was what it was ;) |
|
I don't think this PR needs to be considered WIP anymore. |
|
Thanks @drdavella and @Cadair! |
I took @Cadair's work from #5770 and rebased it on the current
master. The tests pass for me locally in both Python 2.7 and 3.6, but maybe integration testing will reveal some issues that I missed. It might be good to consider this WIP for the moment.