Repository navigation
Update config file in anticipation of future testing updates - #6449
Conversation
|
Hi there @drdavella 👋 - thanks for the pull request! I'm just a friendly 🤖 that checks for issues related to the changelog and making sure that this pull request is milestoned and labelled correctly. This is mainly intended for the maintainers, so if you are not a maintainer you can ignore this, and a maintainer will let you know if any action is required on your part 😃. Everything looks good from my point of view! 👍 |
|
This looks all OK to me as well; not sure a changelog entry is needed. |
|
Re: change log. I agree that it is not needed. |
|
@drdavella - I think this is also ready, though could you remove the changelog entry here as well? @bsipocz, @astrofrog - if you can have a look that would be great, though I think it is not essential as this seems quite obviously correct. |
|
|
||
| - Fixed issue running doctests with pytest>=3.2. [#6423] | ||
|
|
||
| - In anticipation of supporting test runs directly from ``pytest``, fixed |
There was a problem hiding this comment.
The issue with this changelog entry is that it means that we are definitely committing to supporting running tests directly from pytest. Can you write the changelog entry in a way that doesn't imply this?
There was a problem hiding this comment.
This has been fixed.
b707205 to
6529077
Compare
| [pytest] | ||
| minversion = 2.8 | ||
| norecursedirs = ".tox" "build" "docs[\/]_build" "docs[\/]generated" "astropy[\/]extern" "astropy[\/]utils[\/]compat[\/]futures" | ||
| norecursedirs = ".*" "*.egg-info" "build" "docs[\/]_build" "docs[\/]generated" "astropy[\/]extern" "astropy[\/]utils[\/]compat[\/]futures" "astropy_helpers" |
There was a problem hiding this comment.
This could probably be simplified using testpaths (requires pytest 2.8+, which probably explains why it was not used before).
|
Need a rebase to resolve conflict. FYI. |
|
@pllim - I'm on it. Doing the rebase now, and will merge once it's pushed back up. |
505f973 to
cf80b04
Compare
Update config file in anticipation of future testing updates
6 participants
In anticipation of eventually being able to invoke tests directly from
pytest, it is necessary to updatesetup.cfgto make sure all top-level directories that we want to ignore during testing are actually being ignored.Also, according to the pytest documentation we need to add the
--pyargscommand line argument since our tests are integrated with application code.These changes are based on work from #6437. Even if that PR is not integrated as-is, this is a necessary update.