Repository navigation
Fix HDF5 connect import errors - #6610
Conversation
|
Hi there @pllim 👋 - thanks for the pull request! I'm just a friendly 🤖 that checks for issues related to the changelog and making sure that this pull request is milestoned and labelled correctly. This is mainly intended for the maintainers, so if you are not a maintainer you can ignore this, and a maintainer will let you know if any action is required on your part 😃. Everything looks good from my point of view! 👍 If there are any issues with this message, please report them here |
|
@pllim - if this fixes the issue, can it be backported? The bug is present on 2.0.2, too. |
|
I'll have a look at it later. But does it fix the |
|
@bsipocz , I think this only affects Python 3, so I thought if people really have problem with this in Python 3, they should just upgrade to v3. But then again, if backporting this is not painful, why not? @MSeifert04 , I could do the import on fresh interpreter successfully locally, but it is good to have someone else also test this. |
|
OK, I'll try to backport, but won't push it too hard if it's not a clean one. |
|
|
||
| import numpy as np | ||
|
|
||
| # DEV NOTE: Do not import anything from astropy.table here. |
There was a problem hiding this comment.
Could you leave a ref to the issue?
There was a problem hiding this comment.
Never seen DEV NOTE: before. Any reason it's not a normal NOTE:?
Just wondering because neither PyCharm nor Spyder visually highlight this.
There was a problem hiding this comment.
Thanks for checking! I made up "DEV NOTE" (as this only affects developers who want to add code to this file). I'll address these comments shortly.
bsipocz
left a comment
bsipocz
left a comment
There was a problem hiding this comment.
The import works for me on a new interpreter.
astrofrog
left a comment
astrofrog
left a comment
There was a problem hiding this comment.
Looks good but please change DEV NOTE to NOTE as mentioned above
pllim
added
the
zzz 💤 merge-when-ci-passes
|
Since this gotten 3 approvals, I added the "merge when CI passes" tag. Addressed comments, squashed, rebased, and even threw in a bonus change log! |
|
Thanks @pllim! It passed everything except the OSX that I;ve cancelled. |
MSeifert04
removed
the
zzz 💤 merge-when-ci-passes
4 participants
Fix #6604 (maybe? UPDATE: yes.)