Repository navigation
Increase coverage - #7697
Increase coverage#7697
Conversation
|
Hi there @aleksandr-bakanov 👋 - thanks for the pull request! I'm just a friendly 🤖 that checks for issues related to the changelog and making sure that this pull request is milestoned and labeled correctly. This is mainly intended for the maintainers, so if you are not a maintainer you can ignore this, and a maintainer will let you know if any action is required on your part 😃. Everything looks good from my point of view! 👍 If there are any issues with this message, please report them here. |
| return Angle(self.to(u.milliarcsecond, u.parallax())) | ||
|
|
||
|
|
||
| # Looks like this function isn't used anywhere. Should it be removed? |
There was a problem hiding this comment.
Correct, looks like I didn't notice it in a155850, where I made Distance a subclass of SpecificTypeQuantity, which made this unnecessary.
Do delete it as part of this PR!
There was a problem hiding this comment.
Done, function has been removed.
| return 1.0 | ||
|
|
||
| if np.iscomplex(scale): # scale is complex | ||
| # Looks like this condition is always false. From np.iscomplex docs: |
There was a problem hiding this comment.
Coincidentally, I've been reworking this particular stanza in #7649, so I think it may be best to leave it out here. But I would appreciate if you could have a look at that PR...
There was a problem hiding this comment.
Got it, I've removed my comment.
|
|
||
| def test_sanitize_scale(): | ||
| assert sanitize_scale( complex(2, _float_finfo.eps) ) == 2 | ||
| assert sanitize_scale( complex(_float_finfo.eps, 2) ) == 2j No newline at end of file |
There was a problem hiding this comment.
CR has been added.
|
The travis failure is due to the missing newline; the circle-ci failure is unrelated, though may indicate you have to rebase off current master, as I think there were some fixes put in recently. @bsipocz? |
|
Yes, circleCI is fixed in master, so a rebase should solve it. |
Coverage is increased for coordinates.distances and units.utils.
|
Looks all OK now, thanks! Merging... |
4 participants
A small increasing of coverage for:
coordinates.distancesunits.utils