Repository navigation
Fix bug in the frame attributes references for Galactocentric frame - #9582
Conversation
pllim
added
Bug
Affects-dev
|
In the spirit of #7928, please run these new tests without ignoring warnings and see if they introduce any new warnings. If so, please handle the warnings accordingly. Thanks! |
|
I copied the setup.cfg from #7928 and ran |
|
@pllim Now I did - still no warnings! |
|
Thanks for checking, @adrn! |
eteq
left a comment
eteq
left a comment
There was a problem hiding this comment.
Mostly good, but one comment that should probably be addressed in some way so that the test doesn't bleed over to other tests accidentally
eteq
left a comment
eteq
left a comment
There was a problem hiding this comment.
LGTM now and pretty straightforward, so merging!
| # Note: this is necessary because the doctests may alter the state of the | ||
| # class globally and simultaneously when the tests are run in parallel | ||
| reset_galactocentric_defaults() | ||
| # reset_galactocentric_defaults() |
There was a problem hiding this comment.
So is this line supposed to be removed?
There was a problem hiding this comment.
Indeed, no reason to just comment it out, it is now done in setup and teardown. Indeed, the comment above can go too...
Remove unused code as follow up of astropy#9582
Remove unused code as follow up of astropy#9582
Remove unused code as follow up of astropy#9582 Handle failures cased by numpy/numpy#8945
Fix bug in the frame attributes references for Galactocentric frame
Remove unused code as follow up of astropy#9582 Handle failures cased by numpy/numpy#8945
4 participants
Description
While working on astrofrog#91 to write a what's new entry for the changes to
Galactocentric, I noticed that the dictionary of references (i.e. scientific papers that the parameter values come from) was not being properly handled. This adjusts the logic to fix how references are stored, and adds a test.