Repository navigation
Refactor infrastructure as described in astropy-helpers removal APE - #9726
Conversation
ac1daa3 to
40d5c3a
Compare
40d5c3a to
a3ce912
Compare
|
@astrofrog - this is very nice indeed! While I like seeing everything together (and especially that almost everything leads to code reduction rather than increase!!), I do wonder if it isn't best to actually merge roughly following the order you have your commits, so we can discuss smaller pieces in one place. For instance, it would seem that 69df655, which moves packaging information to As another example, the |
|
@mhvk - I agree that some things here can be broken out into standalone PRs - some of them have to be done together though, e.g. pyproject.toml and tox. I'll take a look tomorrow at what could be split out and merged first. |
I would rather switch straight to Actions? |
Yes we should discuss options next week! But in any case I want to not mix that up with this PR. |
astrofrog
added
the
zzz 💤 astropy-helpers-removal
3318897 to
0484579
Compare
48d2a3d to
fefd2be
Compare
…in version if setuptools_scm is installed
Co-Authored-By: P. L. Lim <[email protected]>
90a4ba9 to
823dbbb
Compare
|
@pllim - done! |
|
My sense would be to get this in. Any objections? |
|
Do it! I have two follow-on branches already 😛 |
🚢
|
OK then, I'm good with merging! @astrofrog had previously asked the coordination committee about process for approval of this PR, so I'm speaking now with my CoCo hat on. |
|
Merged. Thank you, @astrofrog and everyone involved! 🎉 |
|
🚀 🚀 🎉 🎆 👯♀️ 👯♂️ |
|
Thanks, indeed, @astrofrog and everyone else! |
|
Thanks for merging this! And please don't hesitate to ping me or @Cadair if you run into any issues locally or in future pull requests 🙏 |
|
Thank you to everyone who made this PR happen! I'd also like to thank everyone who has contributed to astropy-helpers over the last several years, as it has been really helpful to the community during the time that it has been around. |
|
Seconded! I've been convinced over this PR how great it is to get rid of astropy helpers, but it made things much easier when these new nifty tools weren't around! |
|
I had been planning to review this but it's fine that it got merged - @pllim is definitely right, I can always do my own PR with any changes, because big-picture I was already fine with it! |
10 participants
This PR removes astropy-helpers in the core package and update the infrastructure as described in the APE A roadmap for package infrastructure without astropy-helpers. I am putting this up ahead of the coordination meeting in Socorro, to make it easier to see what the changes would be and discuss specific changes.
The main things this does is:
ah_bootstrap.pypyproject.tomlfile describing the build-time dependencies (see PEP 517 and PEP 518)setup_package.pyfiles tosetup.cfgASTROPY_DEBUGas a way to control whether to compile extensions in debug modeI've split out some of the changes into individual self-contained PRs to make the reviewing process a little easier. Specifically, the other PRs that should be reviewed first are:
I've also pushed a 4.1.dev tag to make sure that setuptools_scm works properly (how this should be done will be detailed in the packaging docs). For anyone reviewing this, I've tried to keep the commits as tidy as possible, and would recommend looking at individual commits in turn.
Things that I won't do as part of this PR and can be done in follow-ups instead:
--readonlyoption (Implement equivalent of --readonly option for testing with new infrastructure #9852)EDIT: Close #9871