This repository was archived by the owner on Nov 11, 2024. It is now read-only.
Repository navigation
Fixes an issue with the build_sphinx test - #111
Merged
Merged
Conversation
…he cwd correctly, and was also copying more of astropy_helpers than was necessary.
…ting the Travis builds. Don't be as strict about where the 'build succeeded' message appears in the Sphinx output. (Why do we even do this? Does sphinx not produce a usable return code?)
Contributor
|
👍 |
1 similar comment
Member
|
👍 |
Member
Author
|
Ah, this finally finished running. Now I can move ahead... |
embray
added a commit
that referenced
this pull request
Dec 11, 2014
Fixes an issue with the build_sphinx test
Member
Author
|
Should have a PR up soon for the command hooks. |
embray
added a commit
that referenced
this pull request
Dec 31, 2014
Fixes an issue with the build_sphinx test Conflicts: astropy_helpers/tests/test_setup_helpers.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fix that I accidentally rolled into #110, but I figured it should probably be pulled out as a separate change.
This one is a little hard to explain, but the main issue is that this was copying the entire astropy_helpers source directory into the temp dir, rather than just the
astropy_helperspackage itself. This included, for example, all my.toxdirectories which can get quite huge, slowing down the test run and filling up/tmp. So this should fix that, I think. This should be merged first, then #110 rebased on top of it.