This repository was archived by the owner on Nov 11, 2024. It is now read-only.
Repository navigation
Test command refactor - #184
Merged
Merged
Conversation
…s is just a matter of porting the change originally made in 1068e26 to work in the v1.0 release series.
…lder versions of Astropy anyways). Add multiple ways of getting a ./setup.py test command compatible with different versions of astropy (or lack of astropy).
…ar--like I already did this a few weeks ago...)
embray
added a commit
to embray/astropy
that referenced
this pull request
Sep 22, 2015
… in astropy_helpers itself. This makes up for a bug introduced in astropy/astropy-helpers#184 where astropy_helpers.command.test attempts to import astropy (just to check whether a class is importable) but that causes things to go haywire if _ASTROPY_SETUP_ hasn't been set yet.
embray
added a commit
to embray/astropy
that referenced
this pull request
Sep 22, 2015
… in astropy_helpers itself. This makes up for a bug introduced in astropy/astropy-helpers#184 where astropy_helpers.command.test attempts to import astropy (just to check whether a class is importable) but that causes things to go haywire if _ASTROPY_SETUP_ hasn't been set yet.
embray
added a commit
to embray/astropy
that referenced
this pull request
Sep 23, 2015
… in astropy_helpers itself. This makes up for a bug introduced in astropy/astropy-helpers#184 where astropy_helpers.command.test attempts to import astropy (just to check whether a class is importable) but that causes things to go haywire if _ASTROPY_SETUP_ hasn't been set yet.
embray
added a commit
to embray/astropy
that referenced
this pull request
Sep 23, 2015
… in astropy_helpers itself. This makes up for a bug introduced in astropy/astropy-helpers#184 where astropy_helpers.command.test attempts to import astropy (just to check whether a class is importable) but that causes things to go haywire if _ASTROPY_SETUP_ hasn't been set yet.
This was referenced Sep 23, 2015
embray
added a commit
to embray/astropy_helpers
that referenced
this pull request
Sep 29, 2015
…o always default to verbose results
embray
added a commit
that referenced
this pull request
Sep 30, 2015
Fixed a regression introduced by by #184 that caused testing to always default to verbose results
This was referenced Nov 20, 2015
dhomeier
pushed a commit
to dhomeier/astropy
that referenced
this pull request
Dec 17, 2015
… in astropy_helpers itself. This makes up for a bug introduced in astropy/astropy-helpers#184 where astropy_helpers.command.test attempts to import astropy (just to check whether a class is importable) but that causes things to go haywire if _ASTROPY_SETUP_ hasn't been set yet.
dhomeier
pushed a commit
to dhomeier/astropy
that referenced
this pull request
Jun 12, 2016
… in astropy_helpers itself. This makes up for a bug introduced in astropy/astropy-helpers#184 where astropy_helpers.command.test attempts to import astropy (just to check whether a class is importable) but that causes things to go haywire if _ASTROPY_SETUP_ hasn't been set yet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the change that goes along with astropy/astropy#4020. By default this will try to load the test command from
astropy.tests. However, it still keeps a copy of the old test command implementation that lived in astropy_helpers, so that will continue to work when used with older versions of Astropy.This also provides a dummy test command so that the command at least shows up as available without Astropy installed (but doesn't actually do anything without astropy.tests being available).