This repository was archived by the owner on Nov 11, 2024. It is now read-only.
Repository navigation
Test temp root - #187
Closed
embray wants to merge 2 commits into
Closed
Test temp root#187embray wants to merge 2 commits into
embray wants to merge 2 commits into
Conversation
Member
Author
|
Oops, I sort of did this backwards. Hold on... |
embray
force-pushed
the
test-temp-root
branch
from
September 17, 2015 21:31
ec2bcd5 to
30239ba
Compare
embray
added a commit
to embray/astropy_helpers
that referenced
this pull request
Sep 17, 2015
(ports astropy#187 to master) Conflicts: astropy_helpers/test_helpers.py
Member
Author
|
I'm actually going to close this PR. Per the discussion in astropy/astropy#4164 this may not be the best approach to fix the original issue. I'm still going to keep #188--the new feature may be useful to have at some point. But it can wait 'til the next feature release and is less imperative. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is needed as part of the solution for astropy/astropy#4164, which can then be resolved by setting a default temp-root option in the setup.cfg for astropy (or other package). Tempting to just make this the default, but leaving as is for now.
A separate PR will be needed to implement this for v1.1.0.