Repository navigation
Bundle imageutils for photutils 0.1 release - #132
Conversation
|
Ideally we would use a submodule, but I don't know if it's possible. |
|
A submodule is possible, so it's more a question of whether people using photutils from git will remember to checkout the submodule. |
|
Yeah, but this it's a "solved problem" both in IPython and OTOH, it might not be worth it given that it's only a transient situation that |
|
I'm 👍 on copying the files into |
|
@cdeil - you mean just for the release, or actually tracking them in git? The latter is mildly problematic because we'll have to do a lot of updates given the rate of change in |
Not sure which is better ... I'm fine with any scheme that works. |
|
@cdeil - I thought the idea is that a lot of stuff that's getting added now in |
|
@eteq - Everything |
|
It turns out that it's easier to include the source files by hand because including it as a submodule means we also have the root of the imageutils directory which we don't want - so unless there are any objections, I will go ahead and merge this (without this, it is not possible to run asv benchmarks since it requires all dependencies to be on pypi, and I think we are not planning on releasing imageutils). |
|
In any case, development on imageutils has slowed down a bit (because what is there is close to converged) so the rapid development is no longer really an issue. |
|
@cdeil or @larrybradley - does this seem ok to you? |
|
Failing because of astropy/imageutils#22 |
46f62b3 to
d8cc0d5
Compare
|
Should be fixed now. |
|
(I there are no objections I will merge this evening since we can always switch to a submodule if we want) |
|
Can astropy/imageutils#17 be merged and included in this PR? I never merged it because I was expecting detailed comments. It may not address the needs of every affiliated package, but it's definitely better (and cleaner API) than what's currently in |
|
@larrybradley - sounds good, I'll go and take a look at that PR |
d8cc0d5 to
f2ba132
Compare
|
@larrybradley - I've merged astropy/imageutils#17 and have updated this PR. |
|
@astrofrog - ah, good point about the problem of imageutil's root being the wrong thing... So I guess this works, then. |
f2ba132 to
6bc6a64
Compare
6bc6a64 to
76b7a57
Compare
Bundle imageutils for photutils 0.1 release
As discussed in astropy/imageutils#15, for the photutils 0.1 release we should bundle
imageutilsinphotutils/extern, because it will not be available in the Astropy core asastropy.imageyet.Technically this can be done by copying over files into
photutils/externor maybe by creating a git submodule inphotutils/extern... to be investigated / discussed here.cc @larrybradley @astrofrog