Skip to content

Using system pytest rather than astropy bundled - #491

Merged
bsipocz merged 5 commits into
astropy:masterfrom
bsipocz:pytest_stop_using_astropy
May 26, 2017
Merged

bsipocz merged 5 commits into
astropy:masterfrom
bsipocz:pytest_stop_using_astropy

Conversation

@bsipocz

@bsipocz bsipocz commented Jan 12, 2017 •

Copy link
Copy Markdown
Member

astropy core is considering removing the bundled pytest (see astropy/astropy#5509), so I use photutils to see how badly this idea affect affiliates (e.g. we may see pytest 3.0.x related failures).

@larrybradley

Copy link
Copy Markdown
Member

Thanks, @bsipocz. Many travis tests are failing with "Fetching package metadata ...An unexpected error has occurred, please consider sending the following traceback to the conda GitHub issue tracker at:...". Is this a conda version mismatch issue?

@bsipocz

bsipocz commented Jan 13, 2017

Copy link
Copy Markdown
Member Author

@larrybradley - I've never seen that before, will investigate later today.

@bsipocz

bsipocz commented Jan 13, 2017

Copy link
Copy Markdown
Member Author

It seems that restarting the build will solve the issue (it worked for one build, now restarted all of them).

@larrybradley

Copy link
Copy Markdown
Member

Thanks. All checks have passed now.

@bsipocz

bsipocz commented Jan 13, 2017

Copy link
Copy Markdown
Member Author

Do you think we need to add pytest to the requirements and thus changelog or is it coming with python by default?

@larrybradley

Copy link
Copy Markdown
Member

In the installation docs we state that photutils.test() is a way to run the tests for an installed version, so at the very least we also should mention there that pytest is required to run the tests. Since pytest is required only to run the tests, I'm not sure if we should formally make it a package requirement or not. What will astropy do? 😄

@bsipocz bsipocz changed the title Using system pytest rather than astropy bundled WIP: Using system pytest rather than astropy bundled Jan 18, 2017
@bsipocz
bsipocz force-pushed the pytest_stop_using_astropy branch from 9d913f1 to 0faa3fb Compare April 12, 2017 16:50
@bsipocz

bsipocz commented Apr 12, 2017 •

Copy link
Copy Markdown
Member Author

The last commit here should fix the unittest issue we see in #532. So we either go ahead and merge this (I think it shouldn't matter whether upstream astropy/astropy#5694 gets merged or not), or that commit can be cherry-picked into that PR.

@bsipocz bsipocz changed the title WIP: Using system pytest rather than astropy bundled Using system pytest rather than astropy bundled Apr 12, 2017
@bsipocz
bsipocz force-pushed the pytest_stop_using_astropy branch from 60a565c to 7e45ddd Compare April 13, 2017 16:02
@bsipocz

bsipocz commented Apr 13, 2017

Copy link
Copy Markdown
Member Author

astropy LTS is not compatible with pytest3 (astropy/astropy#4607 (comment)), so I've changed it to run with python3.5

@bsipocz

bsipocz commented Apr 19, 2017

Copy link
Copy Markdown
Member Author

@larrybradley - Should we go ahead with this? Having pytest3 would solve tons of failures in #532.

@larrybradley

Copy link
Copy Markdown
Member

@bsipocz Yes, let's go ahead with this. Many thanks!

@bsipocz

bsipocz commented Apr 19, 2017

Copy link
Copy Markdown
Member Author

It may not work with LTS, that case we will need to limit astropy's version for isophot testing. I'll keep an eye on CI here and in the other PR, too.

@bsipocz
bsipocz force-pushed the pytest_stop_using_astropy branch 2 times, most recently from 80d9aa3 to b3b8f46 Compare April 19, 2017 16:57
@bsipocz

bsipocz commented Apr 19, 2017 •

Copy link
Copy Markdown
Member Author

This is now depends on astropy/ci-helpers#184

@bsipocz
bsipocz force-pushed the pytest_stop_using_astropy branch from b3b8f46 to 85b8fc7 Compare April 19, 2017 23:59
@bsipocz
bsipocz force-pushed the pytest_stop_using_astropy branch from 85b8fc7 to 4d6e8b0 Compare May 18, 2017 12:17
@bsipocz bsipocz added this to the 0.4 milestone May 19, 2017
@larrybradley

Copy link
Copy Markdown
Member

@bsipocz I fixed the biweight failures, so if you rebase this it should pass now.

@bsipocz
bsipocz force-pushed the pytest_stop_using_astropy branch from f0af969 to ff7c665 Compare May 25, 2017 19:31
@larrybradley

Copy link
Copy Markdown
Member

@bsipocz Is this ready to merge?

@bsipocz
bsipocz merged commit 8c3ac18 into astropy:master May 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants