Repository navigation
Using system pytest rather than astropy bundled - #491
Conversation
|
Thanks, @bsipocz. Many |
|
@larrybradley - I've never seen that before, will investigate later today. |
|
It seems that restarting the build will solve the issue (it worked for one build, now restarted all of them). |
|
Thanks. All checks have passed now. |
|
Do you think we need to add pytest to the requirements and thus changelog or is it coming with python by default? |
|
In the installation docs we state that |
9d913f1 to
0faa3fb
Compare
|
The last commit here should fix the unittest issue we see in #532. So we either go ahead and merge this (I think it shouldn't matter whether upstream astropy/astropy#5694 gets merged or not), or that commit can be cherry-picked into that PR. |
60a565c to
7e45ddd
Compare
|
astropy LTS is not compatible with pytest3 (astropy/astropy#4607 (comment)), so I've changed it to run with python3.5 |
|
@larrybradley - Should we go ahead with this? Having pytest3 would solve tons of failures in #532. |
|
@bsipocz Yes, let's go ahead with this. Many thanks! |
|
It may not work with LTS, that case we will need to limit astropy's version for isophot testing. I'll keep an eye on CI here and in the other PR, too. |
80d9aa3 to
b3b8f46
Compare
|
This is now depends on astropy/ci-helpers#184 |
b3b8f46 to
85b8fc7
Compare
85b8fc7 to
4d6e8b0
Compare
|
@bsipocz I fixed the biweight failures, so if you rebase this it should pass now. |
f0af969 to
ff7c665
Compare
|
@bsipocz Is this ready to merge? |
astropy core is considering removing the bundled pytest (see astropy/astropy#5509), so I use photutils to see how badly this idea affect affiliates (e.g. we may see pytest 3.0.x related failures).