Skip to content

Support for non-default dataclass fields (continuation of stale PR, https://github.com/astropy/sphinx-automodapi/pull/116) - #208

Merged
bsipocz merged 4 commits into
astropy:mainfrom
lpsinger:nondefault-fields
Apr 28, 2025
Merged

bsipocz merged 4 commits into
astropy:mainfrom
lpsinger:nondefault-fields

Conversation

@lpsinger

@lpsinger lpsinger commented Apr 28, 2025 •

Copy link
Copy Markdown
Contributor

@codecov

codecov Bot commented Apr 28, 2025 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 70.37037% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.69%. Comparing base (be65dd1) to head (ec44299).
⚠️ Report is 25 commits behind head on main.

Files with missing lines Patch % Lines
sphinx_automodapi/automodsumm.py 20.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #208      +/-   ##
==========================================
- Coverage   90.05%   89.69%   -0.37%     
==========================================
  Files          31       31              
  Lines        1227     1252      +25     
==========================================
+ Hits         1105     1123      +18     
- Misses        122      129       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

lpsinger added a commit to m4opt/m4opt that referenced this pull request Apr 28, 2025
@pllim
pllim requested a review from bsipocz April 28, 2025 15:40
@pllim pllim added this to the v0.20.0 milestone Apr 28, 2025
@pllim

pllim commented Apr 28, 2025

Copy link
Copy Markdown
Member

Thank you!

@bsipocz bsipocz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @lpsinger. This PR slipped through the cracks multiple times for no apparent reasons, thanks for resurrecting and finishing it up.

@bsipocz
bsipocz merged commit 6ce8845 into astropy:main Apr 28, 2025
@lpsinger
lpsinger deleted the nondefault-fields branch April 28, 2025 19:40
weizmannk pushed a commit to weizmannk/m4opt that referenced this pull request May 9, 2025
weizmannk pushed a commit to weizmannk/m4opt that referenced this pull request May 12, 2025
@lpsinger

Copy link
Copy Markdown
Contributor Author

@bsipocz, would you please do a release to pick up this change?

@bsipocz

bsipocz commented Jun 12, 2025

Copy link
Copy Markdown
Member

Aye, I'll cut one later this afternoon. Thanks for the ping.

@bsipocz

bsipocz commented Jun 12, 2025

Copy link
Copy Markdown
Member

Release is on pypi, conda-forge can take a few hours to follow.

@loriab loriab mentioned this pull request Jun 13, 2025
26 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support for typing and dataclass fields

3 participants