Don't overrider NODE_V8_COVERAGE #70

Activity

1. shinnn commented on Apr 20, 2019

   

   shinnn

   on Apr 20, 2019

   Contributor

   More actions

   Good idea. PR welcome.

   The patch would mainly update the following two lines:

   • c8/lib/parse-args.js

     Line 64 in 5ea4313

     default: './coverage/tmp',

     Use process.env.NODE_V8_COVERAGE as a fallback if it exists, instead of './coverage/tmp'

   • c8/bin/c8.js

     Line 29 in 5ea4313

     process.env.NODE_V8_COVERAGE = argv.tempDirectory

     Don't override NODE_V8_COVERAGE if it exists
2. shinnn

   added

   feature-request

   good first issue

   help wantedIssue is well defined but needs assignmentIssue is well defined but needs assignment

   on Apr 20, 2019
3. kilianc

   added 4 commits that reference this issue on Apr 20, 2019

   fix: do not override NODE_V8_COVERAGE if set (bcoe#70)

   71c44e1

   fix: do not override NODE_V8_COVERAGE if set (bcoe#70)

   0706789

   fix: do not override NODE_V8_COVERAGE if set (bcoe#70)

   f4c9d66

   fix: do not override NODE_V8_COVERAGE if set (bcoe#70)

   976b33c
4. kilianc

   added a commit that references this issue on May 6, 2019

   fix: do not override NODE_V8_COVERAGE if set (bcoe#70)

   da41f80
5. bcoe

   added a commit that references this issue on Jun 23, 2019

   fix: do not override NODE_V8_COVERAGE if set (#70)

   8bb67b0
6. bcoe commented on Sep 6, 2019

   

   bcoe

   on Sep 6, 2019

   Owner

   More actions

   @kilianc can you confirm that this is now working for you?

   👍React with 👍1Reacted by Kilian Ciuffolo
7. bcoe

   closed this as completedon Sep 6, 2019
8. github-actions

   added 2 commits that reference this issue on Apr 2, 2023

   chore(release): 1.0.0 [skip ci]

   ...

   8a76426

   chore(release): 1.0.0 [skip ci]

   ...

   496d2ae
9. mcknasty

   added a commit that references this issue on Feb 2, 2024

   fix: do not override NODE_V8_COVERAGE if set (bcoe#70)

   43e2346