Repository navigation
flutter: Wrap Support - #204
Merged
Merged
Conversation
Owner
|
There are some many things that are hard in Flutter. Test if an element with fill on width/height will work well, I think it won't. But I can merge, I guess it is better than nothing. |
Contributor
Author
|
I checked the behaviour for some ui layouts, since Figma only supports single wrap type unlike Flutter, I checked fill for height property. Since I use this plugin in production, I will try to keep the code up-to-date for more use cases. |
Owner
|
Thanks. I'll merge. If you have issues, please raise!!! |
Contributor
Author
|
Will do
…On Wed, 12 Mar, 2025, 12:15 Bernardo Ferrari, ***@***.***> wrote:
Thanks. I'll merge. If you have issues, please raise!!!
—
Reply to this email directly, view it on GitHub
<#204 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGMMVHJU46J235GJUMCIKQL2T7JY3AVCNFSM6AAAAABYZL3WP6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMJWG4YDSMRZGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
[image: bernaferrari]*bernaferrari* left a comment
(bernaferrari/FigmaToCode#204)
<#204 (comment)>
Thanks. I'll merge. If you have issues, please raise!!!
—
Reply to this email directly, view it on GitHub
<#204 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGMMVHJU46J235GJUMCIKQL2T7JY3AVCNFSM6AAAAABYZL3WP6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMJWG4YDSMRZGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Owner
|
Apparently there are conflicts, I can totally 100% fix them myself, but if you want to have the contribution under your profile I will need you to fix it :( |
Contributor
Author
|
Will push with a rebase
…On Thu, 13 Mar, 2025, 11:48 Bernardo Ferrari, ***@***.***> wrote:
Apparently there are conflicts, I can totally 100% fix them myself, but if
you want to have the contribution under your profile I will need you to fix
it :(
—
Reply to this email directly, view it on GitHub
<#204 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGMMVHOEEOLA72H25SMRENL2UEPMRAVCNFSM6AAAAABYZL3WP6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMRQGA4TONJWGM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
[image: bernaferrari]*bernaferrari* left a comment
(bernaferrari/FigmaToCode#204)
<#204 (comment)>
Apparently there are conflicts, I can totally 100% fix them myself, but if
you want to have the contribution under your profile I will need you to fix
it :(
—
Reply to this email directly, view it on GitHub
<#204 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGMMVHOEEOLA72H25SMRENL2UEPMRAVCNFSM6AAAAABYZL3WP6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMRQGA4TONJWGM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Contributor
Author
|
rebased with latest changes @bernaferrari |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.