Repository navigation
[ImgBot] Optimize images - #7
Open
imgbot[bot] wants to merge 2 commits into
Open
imgbot[bot] wants to merge 2 commits into
imgbot[bot] wants to merge 2 commits into
Conversation
*Total -- 4,893.45kb -> 3,646.31kb (25.49%) /engine/src/flutter/testing/ios_scenario_app/ios/Scenarios/ScenariosUITests/golden_two_platform_view_clip_rect_multiple_clips_impeller_iPhone SE (3rd generation)_18.2_simulator.png -- 14.03kb -> 0.87kb (93.83%) /engine/src/flutter/shell/platform/embedder/fixtures/external_texture_metal.png -- 3.18kb -> 0.34kb (89.36%) /engine/src/flutter/testing/ios_scenario_app/ios/Scenarios/ScenariosUITests/golden_platform_view_cliprect_after_moved_multiple_clips_impeller_iPhone SE (3rd generation)_18.2_simulator.png -- 14.80kb -> 1.71kb (88.45%) /engine/src/flutter/testing/ios_scenario_app/ios/Scenarios/ScenariosUITests/golden_platform_view_cliprect_multiple_clips_impeller_iPhone SE (3rd generation)_18.2_simulator.png -- 14.76kb -> 1.71kb (88.42%) /engine/src/flutter/shell/platform/embedder/fixtures/compositor_root_surface_xformation.png -- 9.26kb -> 1.33kb (85.63%) /engine/src/flutter/shell/platform/embedder/fixtures/impeller_test.png -- 3.20kb -> 0.48kb (85%) /engine/src/flutter/testing/ios_scenario_app/ios/Scenarios/ScenariosUITests/golden_two_platform_view_clip_path_multiple_clips_impeller_iPhone SE (3rd generation)_18.2_simulator.png -- 17.49kb -> 3.06kb (82.49%) /engine/src/flutter/testing/ios_scenario_app/ios/Scenarios/ScenariosUITests/golden_platform_view_cliprect_with_transform_multiple_clips_impeller_iPhone SE (3rd generation)_18.2_simulator.png -- 17.86kb -> 3.29kb (81.56%) /engine/src/flutter/testing/ios_scenario_app/ios/Scenarios/ScenariosUITests/golden_platform_view_clippath_with_transform_multiple_clips_impeller_iPhone SE (3rd generation)_18.2_simulator.png -- 16.98kb -> 3.15kb (81.45%) /engine/src/flutter/testing/ios_scenario_app/ios/Scenarios/ScenariosUITests/golden_platform_view_clippath_multiple_clips_impeller_iPhone SE (3rd generation)_18.2_simulator.png -- 15.80kb -> 3.02kb (80.88%) /engine/src/flutter/testing/ios_scenario_app/ios/Scenarios/ScenariosUITests/golden_platform_view_transform_impeller_iPhone SE (3rd generation)_18.2_simulator.png -- 21.19kb -> 4.43kb (79.11%) /engine/src/flutter/testing/ios_scenario_app/ios/Scenarios/ScenariosUITests/golden_platform_view_cliprrect_multiple_clips_impeller_iPhone SE (3rd generation)_18.2_simulator.png -- 16.98kb -> 3.64kb (78.56%) /engine/src/flutter/testing/ios_scenario_app/ios/Scenarios/ScenariosUITests/golden_platform_view_cliprect_after_moved_impeller_iPhone SE (3rd generation)_18.2_simulator.png -- 16.75kb -> 3.66kb (78.14%) /engine/src/flutter/testing/ios_scenario_app/ios/Scenarios/ScenariosUITests/golden_platform_view_cliprect_impeller_iPhone SE (3rd generation)_18.2_simulator.png -- 16.93kb -> 3.71kb (78.1%) /engine/src/flutter/testing/ios_scenario_app/ios/Scenarios/ScenariosUITests/golden_two_platform_view_clip_rect_impeller_iPhone SE (3rd generation)_18.2_simulator.png -- 18.00kb -> 4.06kb (77.47%) /engine/src/flutter/testing/ios_scenario_app/ios/Scenarios/ScenariosUITests/golden_platform_view_cliprrect_impeller_iPhone SE (3rd generation)_18.2_simulator.png -- 18.39kb -> 4.32kb (76.52%) /engine/src/flutter/testing/ios_scenario_app/ios/Scenarios/ScenariosUITests/golden_platform_view_rotate_impeller_iPhone SE (3rd generation)_18.2_simulator.png -- 23.68kb -> 6.33kb (73.27%) /engine/src/flutter/testing/ios_scenario_app/ios/Scenarios/ScenariosUITests/golden_bogus_font_text_impeller_iPhone SE (3rd generation)_18.2_simulator.png -- 22.80kb -> 6.28kb (72.46%) /engine/src/flutter/testing/ios_scenario_app/ios/Scenarios/ScenariosUITests/golden_spawn_engine_works_impeller_iPhone SE (3rd generation)_18.2_simulator.png -- 22.80kb -> 6.28kb (72.46%) /engine/src/flutter/shell/platform/embedder/fixtures/gradient_metal.png -- 44.36kb -> 12.82kb (71.11%) /engine/src/flutter/testing/ios_scenario_app/ios/Scenarios/ScenariosUITests/golden_non_full_screen_flutter_view_platform_view_impeller_iPhone SE (3rd generation)_18.2_simulator.png -- 22.50kb -> 6.61kb (70.62%) /engine/src/flutter/shell/platform/embedder/fixtures/compositor_with_root_layer_only.png -- 1.37kb -> 0.41kb (70.09%) /engine/src/flutter/shell/platform/embedder/fixtures/compositor_platform_layer_with_no_overlay.png -- 2.31kb -> 0.73kb (68.6%) /engine/src/flutter/testing/ios_scenario_app/ios/Scenarios/ScenariosUITests/golden_platform_view_opacity_impeller_iPhone SE (3rd generation)_18.2_simulator.png -- 22.15kb -> 6.97kb (68.52%) /engine/src/flutter/testing/ios_scenario_app/ios/Scenarios/ScenariosUITests/golden_platform_view_impeller_iPhone SE (3rd generation)_18.2_simulator.png -- 22.64kb -> 7.46kb (67.03%) /engine/src/flutter/testing/ios_scenario_app/ios/Scenarios/ScenariosUITests/golden_platform_view_multiple_background_foreground_impeller_iPhone SE (3rd generation)_18.2_simulator.png -- 30.87kb -> 10.58kb (65.73%) /engine/src/flutter/testing/ios_scenario_app/ios/Scenarios/ScenariosUITests/golden_darwin_system_font_impeller_iPhone SE (3rd generation)_18.2_simulator.png -- 30.87kb -> 10.67kb (65.42%) /engine/src/flutter/testing/ios_scenario_app/ios/Scenarios/ScenariosUITests/golden_platform_view_cliprrect_with_transform_multiple_clips_impeller_iPhone SE (3rd generation)_18.2_simulator.png -- 18.99kb -> 6.62kb (65.15%) /engine/src/flutter/testing/ios_scenario_app/ios/Scenarios/ScenariosUITests/golden_platform_view_clippath_with_transform_impeller_iPhone SE (3rd generation)_18.2_simulator.png -- 19.70kb -> 7.16kb (63.67%) /engine/src/flutter/testing/ios_scenario_app/ios/Scenarios/ScenariosUITests/golden_platform_view_cliprect_with_transform_impeller_iPhone SE (3rd generation)_18.2_simulator.png -- 20.61kb -> 7.54kb (63.43%) /engine/src/flutter/testing/ios_scenario_app/ios/Scenarios/ScenariosUITests/golden_platform_view_cliprrect_with_transform_impeller_iPhone SE (3rd generation)_18.2_simulator.png -- 20.29kb -> 7.45kb (63.26%) /engine/src/flutter/testing/ios_scenario_app/ios/Scenarios/ScenariosUITests/golden_platform_view_large_cliprrect_with_transform_multiple_clips_impeller_iPhone SE (3rd generation)_18.2_simulator.png -- 22.57kb -> 8.31kb (63.18%) /engine/src/flutter/lib/ui/fixtures/2_dispose_op_restore_previous.apng.69.png -- 22.81kb -> 8.45kb (62.96%) /engine/src/flutter/lib/ui/fixtures/impeller_2_dispose_op_restore_previous.apng.69.png -- 22.79kb -> 8.45kb (62.94%) /engine/src/flutter/lib/ui/fixtures/2_dispose_op_restore_previous.apng.67.png -- 22.62kb -> 8.42kb (62.77%) /engine/src/flutter/lib/ui/fixtures/impeller_2_dispose_op_restore_previous.apng.67.png -- 22.60kb -> 8.42kb (62.75%) /engine/src/flutter/lib/ui/fixtures/2_dispose_op_restore_previous.apng.68.png -- 22.58kb -> 8.41kb (62.74%) /engine/src/flutter/lib/ui/fixtures/impeller_2_dispose_op_restore_previous.apng.68.png -- 22.57kb -> 8.41kb (62.72%) /engine/src/flutter/testing/ios_scenario_app/ios/Scenarios/ScenariosUITests/golden_platform_view_large_cliprrect_with_transform_impeller_iPhone SE (3rd generation)_18.2_simulator.png -- 26.17kb -> 10.03kb (61.69%) /engine/src/flutter/shell/platform/embedder/fixtures/compositor_with_platform_layer_on_bottom.png -- 1.42kb -> 0.55kb (61.02%) /engine/src/flutter/testing/resources/performance_overlay_gold_60fps.png -- 16.15kb -> 6.53kb (59.54%) /engine/src/flutter/testing/resources/performance_overlay_gold_90fps.png -- 15.88kb -> 6.46kb (59.33%) /engine/src/flutter/testing/resources/performance_overlay_gold_120fps.png -- 15.88kb -> 6.49kb (59.14%) /engine/src/flutter/testing/ios_scenario_app/ios/Scenarios/ScenariosUITests/golden_platform_view_large_cliprrect_multiple_clips_impeller_iPhone SE (3rd generation)_18.2_simulator.png -- 20.26kb -> 8.35kb (58.81%) /engine/src/flutter/shell/platform/embedder/fixtures/scene_without_custom_compositor_with_xform.png -- 2.39kb -> 1.02kb (57.17%) /engine/src/flutter/testing/ios_scenario_app/ios/Scenarios/ScenariosUITests/golden_platform_view_clippath_impeller_iPhone SE (3rd generation)_18.2_simulator.png -- 20.11kb -> 8.64kb (57.04%) /dev/tools/vitool/test_assets/empty_svg_2_100x50.svg -- 0.18kb -> 0.08kb (56.04%) /engine/src/flutter/testing/ios_scenario_app/ios/Scenarios/ScenariosUITests/golden_two_platform_view_clip_path_impeller_iPhone SE (3rd generation)_18.2_simulator.png -- 23.37kb -> 10.31kb (55.89%) /engine/src/flutter/shell/platform/embedder/fixtures/scene_without_custom_compositor.png -- 2.57kb -> 1.14kb (55.73%) /engine/src/flutter/shell/platform/embedder/fixtures/compositor_software.png -- 2.55kb -> 1.14kb (55.54%) /engine/src/flutter/shell/platform/embedder/fixtures/compositor.png -- 2.55kb -> 1.14kb (55.51%) /engine/src/flutter/testing/ios_scenario_app/ios/Scenarios/ScenariosUITests/golden_platform_view_large_cliprrect_impeller_iPhone SE (3rd generation)_18.2_simulator.png -- 23.99kb -> 11.23kb (53.17%) /engine/src/flutter/testing/ios_scenario_app/ios/Scenarios/ScenariosUITests/golden_two_platform_view_clip_rrect_multiple_clips_impeller_iPhone SE (3rd generation)_18.2_simulator.png -- 26.48kb -> 13.10kb (50.55%) /engine/src/flutter/shell/platform/embedder/fixtures/dpr_xform.png -- 56.25kb -> 29.47kb (47.61%) /engine/src/flutter/shell/platform/embedder/fixtures/vk_gradient.png -- 69.55kb -> 37.59kb (45.95%) /engine/src/flutter/shell/platform/embedder/fixtures/gradient.png -- 69.55kb -> 37.59kb (45.95%) /engine/src/flutter/testing/ios_scenario_app/ios/Scenarios/ScenariosUITests/golden_platform_view_multiple_impeller_iPhone SE (3rd generation)_18.2_simulator.png -- 32.02kb -> 17.57kb (45.14%) /engine/src/flutter/shell/platform/embedder/fixtures/gradient_xform.png -- 70.80kb -> 38.90kb (45.06%) /engine/src/flutter/testing/ios_scenario_app/ios/Scenarios/ScenariosUITests/golden_two_platform_view_clip_rrect_impeller_iPhone SE (3rd generation)_18.2_simulator.png -- 34.29kb -> 19.38kb (43.48%) /engine/src/flutter/shell/platform/embedder/fixtures/vk_dpr_noxform.png -- 61.96kb -> 35.42kb (42.83%) /engine/src/flutter/shell/platform/embedder/fixtures/dpr_noxform.png -- 61.97kb -> 35.43kb (42.82%) /engine/src/flutter/shell/platform/embedder/fixtures/arc_end_caps.png -- 5.87kb -> 3.40kb (42%) /engine/src/flutter/shell/platform/embedder/fixtures/verifyb143464703_soft_noxform.png -- 15.38kb -> 9.92kb (35.47%) /engine/src/flutter/shell/platform/embedder/fixtures/impeller_text_test.png -- 3.25kb -> 2.15kb (33.86%) /dev/manual_tests/macos/Runner/Assets.xcassets/AppIcon.appiconset/app_icon_512.png -- 14.45kb -> 9.69kb (32.93%) /examples/image_list/macos/Runner/Assets.xcassets/AppIcon.appiconset/app_icon_512.png -- 14.45kb -> 9.69kb (32.93%) /dev/a11y_assessments/macos/Runner/Assets.xcassets/AppIcon.appiconset/app_icon_512.png -- 14.45kb -> 9.69kb (32.93%) /examples/hello_world/macos/Runner/Assets.xcassets/AppIcon.appiconset/app_icon_512.png -- 14.45kb -> 9.69kb (32.93%) /dev/integration_tests/flutter_gallery/macos/Runner/Assets.xcassets/AppIcon.appiconset/app_icon_512.png -- 14.45kb -> 9.69kb (32.93%) /examples/api/macos/Runner/Assets.xcassets/AppIcon.appiconset/app_icon_512.png -- 14.45kb -> 9.69kb (32.93%) /dev/integration_tests/ui/macos/Runner/Assets.xcassets/AppIcon.appiconset/app_icon_512.png -- 14.45kb -> 9.69kb (32.93%) /examples/image_list/macos/Runner/Assets.xcassets/AppIcon.appiconset/app_icon_1024.png -- 45.89kb -> 31.58kb (31.18%) /examples/hello_world/macos/Runner/Assets.xcassets/AppIcon.appiconset/app_icon_1024.png -- 45.89kb -> 31.58kb (31.18%) /dev/a11y_assessments/macos/Runner/Assets.xcassets/AppIcon.appiconset/app_icon_1024.png -- 45.89kb -> 31.58kb (31.18%) /dev/manual_tests/macos/Runner/Assets.xcassets/AppIcon.appiconset/app_icon_1024.png -- 45.89kb -> 31.58kb (31.18%) /examples/api/macos/Runner/Assets.xcassets/AppIcon.appiconset/app_icon_1024.png -- 45.89kb -> 31.58kb (31.18%) /dev/integration_tests/flutter_gallery/macos/Runner/Assets.xcassets/AppIcon.appiconset/app_icon_1024.png -- 45.89kb -> 31.58kb (31.18%) /dev/integration_tests/ui/macos/Runner/Assets.xcassets/AppIcon.appiconset/app_icon_1024.png -- 45.89kb -> 31.58kb (31.18%) /engine/src/flutter/docs/rbe/luci.png -- 98.61kb -> 70.27kb (28.73%) /examples/image_list/macos/Runner/Assets.xcassets/AppIcon.appiconset/app_icon_16.png -- 1.40kb -> 1.00kb (28.62%) /examples/hello_world/macos/Runner/Assets.xcassets/AppIcon.appiconset/app_icon_16.png -- 1.40kb -> 1.00kb (28.62%) /dev/a11y_assessments/macos/Runner/Assets.xcassets/AppIcon.appiconset/app_icon_16.png -- 1.40kb -> 1.00kb (28.62%) /examples/api/macos/Runner/Assets.xcassets/AppIcon.appiconset/app_icon_16.png -- 1.40kb -> 1.00kb (28.62%) /dev/integration_tests/ui/macos/Runner/Assets.xcassets/AppIcon.appiconset/app_icon_16.png -- 1.40kb -> 1.00kb (28.62%) /dev/manual_tests/macos/Runner/Assets.xcassets/AppIcon.appiconset/app_icon_16.png -- 1.40kb -> 1.00kb (28.62%) /dev/integration_tests/flutter_gallery/macos/Runner/Assets.xcassets/AppIcon.appiconset/app_icon_16.png -- 1.40kb -> 1.00kb (28.62%) /dev/manual_tests/macos/Runner/Assets.xcassets/AppIcon.appiconset/app_icon_256.png -- 5.79kb -> 4.27kb (26.23%) /examples/image_list/macos/Runner/Assets.xcassets/AppIcon.appiconset/app_icon_256.png -- 5.79kb -> 4.27kb (26.23%) /examples/hello_world/macos/Runner/Assets.xcassets/AppIcon.appiconset/app_icon_256.png -- 5.79kb -> 4.27kb (26.23%) /dev/a11y_assessments/macos/Runner/Assets.xcassets/AppIcon.appiconset/app_icon_256.png -- 5.79kb -> 4.27kb (26.23%) /examples/api/macos/Runner/Assets.xcassets/AppIcon.appiconset/app_icon_256.png -- 5.79kb -> 4.27kb (26.23%) /dev/integration_tests/ui/macos/Runner/Assets.xcassets/AppIcon.appiconset/app_icon_256.png -- 5.79kb -> 4.27kb (26.23%) /dev/integration_tests/flutter_gallery/macos/Runner/Assets.xcassets/AppIcon.appiconset/app_icon_256.png -- 5.79kb -> 4.27kb (26.23%) /engine/src/flutter/lib/ui/fixtures/DashInNooglerHat.jpg -- 346.37kb -> 257.43kb (25.68%) /engine/src/flutter/lib/ui/fixtures/DashInNooglerHat%20WithSpace.jpg -- 346.37kb -> 257.43kb (25.68%) /engine/src/flutter/shell/platform/embedder/fixtures/verifyb143464703.png -- 9.24kb -> 6.89kb (25.48%) /engine/src/flutter/lib/web_ui/test/ui/image/sample_image1.png -- 14.40kb -> 10.83kb (24.76%) /examples/image_list/macos/Runner/Assets.xcassets/AppIcon.appiconset/app_icon_128.png -- 3.20kb -> 2.60kb (18.77%) /examples/hello_world/macos/Runner/Assets.xcassets/AppIcon.appiconset/app_icon_128.png -- 3.20kb -> 2.60kb (18.77%) /examples/api/macos/Runner/Assets.xcassets/AppIcon.appiconset/app_icon_128.png -- 3.20kb -> 2.60kb (18.77%) /dev/a11y_assessments/macos/Runner/Assets.xcassets/AppIcon.appiconset/app_icon_128.png -- 3.20kb -> 2.60kb (18.77%) /dev/integration_tests/ui/macos/Runner/Assets.xcassets/AppIcon.appiconset/app_icon_128.png -- 3.20kb -> 2.60kb (18.77%) /dev/integration_tests/flutter_gallery/macos/Runner/Assets.xcassets/AppIcon.appiconset/app_icon_128.png -- 3.20kb -> 2.60kb (18.77%) /dev/manual_tests/macos/Runner/Assets.xcassets/AppIcon.appiconset/app_icon_128.png -- 3.20kb -> 2.60kb (18.77%) /engine/src/flutter/docs/flutter_logo.png -- 4.16kb -> 3.53kb (15.18%) /dev/tools/vitool/test_assets/illegal_svg_multiple_roots.svg -- 0.10kb -> 0.09kb (12.87%) /dev/tools/vitool/test_assets/empty_svg_1_48x48.svg -- 0.09kb -> 0.08kb (12.77%) /dev/tools/vitool/test_assets/bar_group_opacity.svg -- 0.22kb -> 0.20kb (11.01%) /dev/tools/vitool/test_assets/bars_group.svg -- 0.30kb -> 0.26kb (10.86%) /engine/src/flutter/lib/ui/fixtures/Horizontal.jpg -- 11.08kb -> 9.90kb (10.6%) /dev/tools/vitool/test_assets/bar_group_scale.svg -- 0.23kb -> 0.21kb (9.62%) /dev/tools/vitool/test_assets/bar_group_translate.svg -- 0.24kb -> 0.21kb (9.5%) /dev/tools/vitool/test_assets/leading_space_path_command.svg -- 0.13kb -> 0.12kb (9.49%) /dev/tools/vitool/test_assets/illegal_transform.svg -- 0.24kb -> 0.22kb (9.39%) /engine/src/flutter/lib/ui/fixtures/DisplayP3Logo.jpg -- 4.77kb -> 4.33kb (9.19%) /dev/tools/vitool/test_assets/bar_group_rotate_scale.svg -- 0.25kb -> 0.23kb (8.98%) /dev/tools/vitool/test_assets/illegal_path.svg -- 0.14kb -> 0.13kb (8.33%) /engine/src/flutter/lib/ui/fixtures/four_frame_with_reuse_end.png -- 0.50kb -> 0.46kb (7.78%) /engine/src/flutter/lib/ui/fixtures/DisplayP3Logo.png -- 2.95kb -> 2.73kb (7.44%) /dev/tools/vitool/test_assets/horizontal_bar.svg -- 0.18kb -> 0.17kb (7.14%) /dev/tools/vitool/test_assets/horizontal_bar_relative.svg -- 0.18kb -> 0.17kb (7.1%) /dev/tools/vitool/test_assets/close_path_in_middle.svg -- 0.19kb -> 0.18kb (6.6%) /engine/src/flutter/lib/ui/fixtures/four_frame_with_reuse.gif -- 1.95kb -> 1.84kb (5.46%) /engine/src/flutter/lib/ui/fixtures/impeller_four_frame_with_reuse_end.png -- 0.49kb -> 0.46kb (5.39%) /engine/src/flutter/impeller/fixtures/monkey.png -- 603.17kb -> 572.78kb (5.04%) /engine/src/flutter/lib/ui/fixtures/hello_loop_2.gif -- 28.64kb -> 27.36kb (4.46%) /engine/src/flutter/shell/common/fixtures/hello_loop_2.gif -- 28.64kb -> 27.36kb (4.46%) /engine/src/flutter/impeller/fixtures/blend_mode_src.png -- 33.71kb -> 32.51kb (3.55%) /engine/src/flutter/testing/skia_gold_client/tool/e2e_fixtures/solid_blue_square.png -- 2.35kb -> 2.29kb (2.49%) /engine/src/flutter/testing/skia_gold_client/tool/e2e_fixtures/solid_red_square.png -- 2.67kb -> 2.61kb (2.34%) /engine/src/flutter/lib/ui/fixtures/heart_end.png -- 38.64kb -> 37.80kb (2.17%) /engine/src/flutter/lib/ui/fixtures/impeller_heart_end.png -- 38.63kb -> 37.80kb (2.14%) /engine/src/flutter/testing/skia_gold_client/tool/e2e_fixtures/solid_green_square.png -- 3.48kb -> 3.41kb (1.8%) /engine/src/flutter/lib/ui/fixtures/Horizontal.png -- 24.98kb -> 24.63kb (1.37%) /engine/src/flutter/shell/common/fixtures/shelltest_screenshot.png -- 0.31kb -> 0.31kb (0.63%) /engine/src/flutter/docs/dart_split_aot_compilation.svg -- 107.78kb -> 107.31kb (0.43%) /engine/src/flutter/impeller/fixtures/blend_mode_dst.png -- 170.59kb -> 170.13kb (0.27%) /engine/src/flutter/docs/deferred_components_architecture.svg -- 298.78kb -> 297.96kb (0.27%) /engine/src/flutter/docs/deferred_components_call_lifecycle.svg -- 251.94kb -> 251.49kb (0.18%) /engine/src/flutter/docs/flutter_overview.svg -- 185.94kb -> 185.80kb (0.08%) /engine/src/flutter/impeller/fixtures/kalimba.jpg -- 66.47kb -> 66.46kb (0.01%) /examples/image_list/images/coast.jpg -- 197.60kb -> 197.60kb (0%) /engine/src/flutter/impeller/fixtures/airplane.jpg -- 69.71kb -> 69.71kb (0%) Signed-off-by: ImgBotApp <[email protected]>
bernaferrari
pushed a commit
that referenced
this pull request
Nov 4, 2025
This test passes when run locally as instructed in the README for the devicelab ``` ../../bin/cache/dart-sdk/bin/dart bin/test_runner.dart test -t android_verified_input_test ``` but fails on CI: https://ci.chromium.org/ui/p/flutter/builders/staging/Linux_pixel_7pro%20android_verified_input_test/106/overview ``` [2025-11-03 11:08:04.090018] [STDOUT] stdout: [ ] Original error: ext.flutter.driver: (-32000) Service connection disposed [2025-11-03 11:08:04.090156] [STDOUT] stdout: [ ] Original stack trace: [2025-11-03 11:08:04.090199] [STDOUT] stdout: [ ] #0 new _OutstandingRequest (package:vm_service/src/vm_service.dart:268:34) [2025-11-03 11:08:04.091572] [STDOUT] stdout: [ ] #1 VmService._call.<anonymous closure> (package:vm_service/src/vm_service.dart:1950:25) [2025-11-03 11:08:04.091647] [STDOUT] stdout: [ ] #2 VmService._call (package:vm_service/src/vm_service.dart:1962:8) [2025-11-03 11:08:04.091674] [STDOUT] stdout: [ ] #3 VmService.callServiceExtension (package:vm_service/src/vm_service.dart:1901:14) [2025-11-03 11:08:04.091693] [STDOUT] stdout: [ ] #4 VMServiceFlutterDriver.sendCommand (package:flutter_driver/src/driver/vmservice_driver.dart:327:12) [2025-11-03 11:08:04.091713] [STDOUT] stdout: [ ] #5 FlutterDriver.requestData (package:flutter_driver/src/driver/driver.dart:573:13) [2025-11-03 11:08:04.091733] [STDOUT] stdout: [ ] #6 main.<anonymous closure> (file:///opt/s/w/ir/x/w/rc/tmpv6pcbna2/flutter%20sdk/dev/integration_tests/android_verified_input/test_driver/main_test.dart:28:57) [2025-11-03 11:08:04.091750] [STDOUT] stdout: [ ] <asynchronous suspension> [2025-11-03 11:08:04.091767] [STDOUT] stdout: [ ] #7 Declarer.test.<anonymous closure>.<anonymous closure> (package:test_api/src/backend/declarer.dart:242:9) [2025-11-03 11:08:04.091784] [STDOUT] stdout: [ ] <asynchronous suspension> [2025-11-03 11:08:04.092408] [STDOUT] stdout: [ ] flutter#8 Declarer.test.<anonymous closure> (package:test_api/src/backend/declarer.dart:240:7) [2025-11-03 11:08:04.092472] [STDOUT] stdout: [ ] <asynchronous suspension> [2025-11-03 11:08:04.092502] [STDOUT] stdout: [ ] flutter#9 Invoker._waitForOutstandingCallbacks.<anonymous closure> (package:test_api/src/backend/invoker.dart:282:9) ``` Try copying this configuration used by other tests as a speculative fix. I can't get this test to kick off in presubmit, so I suppose we will just try this. The test is marked bringup anyways so it won't block the tree if this doesn't help. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md --------- Co-authored-by: Gray Mackall <[email protected]>
bernaferrari
pushed a commit
that referenced
this pull request
Feb 12, 2026
Instead of using fake touch events. Before this patch `FlutterViewController` sends two fake touch events (down and up), at `(0, 0)` to the framework to signal that the status bar is tapped on iOS. The scaffold widget and the cupertino page scaffold widget set up gesture detectors to listen for these fake taps, and scroll the "primary" scrollable container to the top in response. This messaging mechanism is sometimes ambiguous, as the framework may interpret that as a pair of regular pointer tap events (for instance in flutter#177992 the modal barrier claims the tap gesture and as a result the modal barrier is dismissed by the fake touch events). This PR changes that to communicate the status bar tap event via a new system channel, and dispatch the events via `WidgetsBindingObserver`s in the framework. See also flutter#177992 (comment) Fixes flutter#177992, fixes flutter#175606 It appears that UIKit also has access to the coordinates of the touch events to determine which scrollable view(s?) to dispatch the scroll to top event to. ```objc * frame #0: 0x00000001032f6520 UIPlayground.debug.dylib`MyScrollViewController.scrollViewShouldScrollToTop(scrollView=0x0000000106014800) at UIScrollView.swift:13:3 frame #2: 0x00000001867c9300 UIKitCore`-[UIScrollView _scrollToTopIfPossible:] + 316 frame #3: 0x00000001867c9604 UIKitCore`-[UIScrollView _scrollToTopFromTouchAtScreenLocation:resultHandler:] + 40 frame #4: 0x0000000186299bbc UIKitCore`__71-[UIWindow _scrollToTopViewsUnderScreenPointIfNecessary:resultHandler:]_block_invoke.358 + 168 frame #5: 0x000000018629981c UIKitCore`-[UIWindow _scrollToTopViewsUnderScreenPointIfNecessary:resultHandler:] + 1212 frame #6: 0x000000018581ed8c UIKitCore`-[UIStatusBarManager _handleScrollToTopAtXPosition:] + 192 frame #7: 0x000000018581eb60 UIKitCore`-[UIStatusBarManager handleTapAction:] + 60 ``` Unfortunately that information is not available to user application. The iOS accessibility bridge currently does create dummy UIScrollViews for each scrollable in the accessibility tree so may be we can take advantage of that in the future. ## Pre-launch Checklist - [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [ ] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
bernaferrari
pushed a commit
that referenced
this pull request
May 29, 2026
…rent (e.g. Table) (flutter#185793) ## Issue Fixes flutter#174133 (and the duplicate flutter#180337). Placing a widget that hosts an `OverlayPortal` — most visibly `Slider`, but anything that calls `OverlayPortalController.show()` before its `OverlayPortal` is mounted — inside a `Table`/`TableRow` crashes during mount with: ``` 'package:flutter/src/rendering/object.dart': Failed assertion: line 2138 pos 12: 'child.owner == owner': is not true. #2 RenderObject.redepthChild #3 _RenderDeferredLayoutBox.redepthChildren overlay.dart:2576 #4 RenderObject.redepthChild #5 RenderObject.adoptChild #6 _RenderTheater._addDeferredChild overlay.dart:1312 #7 _OverlayEntryLocation._addChild overlay.dart:2185 flutter#8 _OverlayPortalElement.insertRenderObjectChild overlay.dart:2447 ... flutter#24 _TableElement.mount.<anonymous closure>... table.dart:303 ``` This is a regression introduced between Flutter 3.32 and 3.35. ## Root cause `Table` defers calling `adoptChild` on its `RenderObject` children until *every* row has been mounted (`_TableElement.insertRenderObjectChild` is a no-op while `_doingMountOrUpdate`; the children are wired in later by `_updateRenderObjectChildren`). Meanwhile `_OverlayPortalElement.mount` runs `super.mount` (which "attaches" the layout surrogate to its parent — but Table swallows it) and then immediately mounts the overlay child, which causes the deferred-layout box to be adopted by the `_RenderTheater`. The theater is attached, so the deferred box receives an owner — *while the layout surrogate has none yet*. When the theater calls `redepthChild(deferredBox)`, the deferred box's `redepthChildren` unconditionally calls `_layoutSurrogate.redepthChild(this)`, which trips the `child.owner == owner` assertion across that owner boundary. ## Fix `_RenderDeferredLayoutBox.redepthChildren` now skips the cross-redepth when the surrogate is not yet attached, mirroring the existing guard in `_RenderLayoutSurrogateProxyBox.redepthChildren`: ```dart if (_layoutSurrogate.attached) { _layoutSurrogate.redepthChild(this); } ``` The depth invariant is restored when the surrogate is finally adopted by its parent: `_RenderLayoutSurrogateProxyBox.redepthChildren` already calls `redepthChild(_deferredLayoutChild)` once that child becomes attached. ## Tests Adds a regression test in `test/widgets/table_test.dart` placing an `OverlayPortal` whose controller is `.show()`'d before mount (mirroring `Slider`) inside a `TableRow`, asserting that no exception is thrown and the overlay child is present. Without this fix the new test reproduces the assertion. With this fix `flutter test test/widgets/table_test.dart`, `test/widgets/overlay_portal_test.dart`, `test/widgets/overlay_test.dart`, `test/widgets/raw_tooltip_test.dart`, `test/widgets/overlay_layout_builder_test.dart`, and `test/material/slider_test.dart` all pass. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I added new tests to check the change I am making. - [x] All existing and new tests are passing. [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo --------- Co-authored-by: Victor Sanni <[email protected]>
bernaferrari
pushed a commit
that referenced
this pull request
Jun 10, 2026
Fixes flutter#184725 This PR makes the tool exit when building with XCode and we didn't parse any build setting. I understand that there are no cases where this map can be empty, as it includes the app bundle ID, which is required when building. If we don't exit, it can show unrelated error messages to the users which could be confusing and hard to debug. For instance, from the linked issue, one could end up getting: `No valid code signing certificates were found` simply because the development team build setting was not available, despite having valid certificates installed. Sample output: ``` [ +63 ms] executing: [/Users/admin/builds/AEFj1IwjB/0/repo/ios/Runner.xcodeproj/] /usr/bin/arch -arm64e xcrun xcodebuild -project /Users/admin/builds/AEFj1IwjB/0/repo/ios/Runner.xcodeproj -scheme Runner -configuration Release -destination generic/platform=iOS -showBuildSettings BUILD_DIR=/Users/admin/builds/AEFj1IwjB/0/repo/build/ios [ ] executing: [/Users/admin/builds/AEFj1IwjB/0/repo/ios/Runner.xcodeproj/] /usr/bin/arch -arm64e xcrun xcodebuild -project /Users/admin/builds/AEFj1IwjB/0/repo/ios/Runner.xcodeproj -scheme Runner -configuration Release -destination generic/platform=iOS -showBuildSettings BUILD_DIR=/Users/admin/builds/AEFj1IwjB/0/repo/build/ios [ +765 ms] Command line invocation: /Applications/Xcode-26.3.0.app/Contents/Developer/usr/bin/xcodebuild -project /Users/admin/builds/AEFj1IwjB/0/repo/ios/Runner.xcodeproj -scheme Runner -configuration Release -destination generic/platform=iOS -showBuildSettings BUILD_DIR=/Users/admin/builds/AEFj1IwjB/0/repo/build/ios Build settings from command line: BUILD_DIR = /Users/admin/builds/AEFj1IwjB/0/repo/build/ios 2026-04-06 17:36:53.692 xcodebuild[9020:45597] Writing error result bundle to /var/folders/4p/084k9rr96ld_w60n8rdr0wtm0000gn/T/ResultBundle_2026-06-04_17-36-0053.xcresult xcodebuild: error: Could not configure request to show build settings: Unable to find a destination matching the provided destination specifier: { generic:1, platform:iOS } Ineligible destinations for the "Runner" scheme: { platform:iOS, id:dvtdevice-DVTiPhonePlaceholder-iphoneos:placeholder, name:Any iOS Device, error:iOS 26.2 is not installed. Please download and install the platform from Xcode > Settings > Components. } [ ] Unexpected failure to get Xcode build settings: ProcessException: Process exited abnormally with exit code 64: Command line invocation: /Applications/Xcode-26.3.0.app/Contents/Developer/usr/bin/xcodebuild -project /Users/admin/builds/AEFj1IwjB/0/repo/ios/Runner.xcodeproj -scheme Runner -configuration Release -destination generic/platform=iOS -showBuildSettings BUILD_DIR=/Users/admin/builds/AEFj1IwjB/0/repo/build/ios Build settings from command line: BUILD_DIR = /Users/admin/builds/AEFj1IwjB/0/repo/build/ios 2026-04-06 17:36:53.692 xcodebuild[9020:45597] Writing error result bundle to /var/folders/4p/084k9rr96ld_w60n8rdr0wtm0000gn/T/ResultBundle_2026-06-04_17-36-0053.xcresult xcodebuild: error: Could not configure request to show build settings: Unable to find a destination matching the provided destination specifier: { generic:1, platform:iOS } Ineligible destinations for the "Runner" scheme: { platform:iOS, id:dvtdevice-DVTiPhonePlaceholder-iphoneos:placeholder, name:Any iOS Device, error:iOS 26.2 is not installed. Please download and install the platform from Xcode > Settings > Components. } Command: /usr/bin/arch -arm64e xcrun xcodebuild -project /Users/admin/builds/AEFj1IwjB/0/repo/ios/Runner.xcodeproj -scheme Runner -configuration Release -destination generic/platform=iOS -showBuildSettings BUILD_DIR=/Users/admin/builds/AEFj1IwjB/0/repo/build/ios. [ +2 ms] Archiving example.com.myapp... [ +25 ms] Migrating AppFrameworkInfo.plist contents [ ] Upgrading AppFrameworkInfo.plist [ ] Upgrading Podfile [ +9 ms] The Swift Package Manager feature is off. Skipping the migration that adds Swift Package Manager integration... [ +6 ms] executing: xattr -r -d com.apple.FinderInfo /Users/admin/builds/AEFj1IwjB/0/repo [+1948 ms] Failed to remove xattr com.apple.FinderInfo from /Users/admin/builds/AEFj1IwjB/0/repo [ +1 ms] executing: [/Users/admin/builds/AEFj1IwjB/0/repo/ios/Runner.xcodeproj/] /usr/bin/arch -arm64e xcrun xcodebuild -project /Users/admin/builds/AEFj1IwjB/0/repo/ios/Runner.xcodeproj -scheme Runner -configuration Release -destination generic/platform=iOS -showBuildSettings BUILD_DIR=/Users/admin/builds/AEFj1IwjB/0/repo/build/ios [ ] executing: [/Users/admin/builds/AEFj1IwjB/0/repo/ios/Runner.xcodeproj/] /usr/bin/arch -arm64e xcrun xcodebuild -project /Users/admin/builds/AEFj1IwjB/0/repo/ios/Runner.xcodeproj -scheme Runner -configuration Release -destination generic/platform=iOS -showBuildSettings BUILD_DIR=/Users/admin/builds/AEFj1IwjB/0/repo/build/ios [ +920 ms] Command line invocation: /Applications/Xcode-26.3.0.app/Contents/Developer/usr/bin/xcodebuild -project /Users/admin/builds/AEFj1IwjB/0/repo/ios/Runner.xcodeproj -scheme Runner -configuration Release -destination generic/platform=iOS -showBuildSettings BUILD_DIR=/Users/admin/builds/AEFj1IwjB/0/repo/build/ios Build settings from command line: BUILD_DIR = /Users/admin/builds/AEFj1IwjB/0/repo/build/ios 2026-04-06 17:36:56.608 xcodebuild[9023:45646] Writing error result bundle to /var/folders/4p/084k9rr96ld_w60n8rdr0wtm0000gn/T/ResultBundle_2026-06-04_17-36-0056.xcresult xcodebuild: error: Could not configure request to show build settings: Unable to find a destination matching the provided destination specifier: { generic:1, platform:iOS } Ineligible destinations for the "Runner" scheme: { platform:iOS, id:dvtdevice-DVTiPhonePlaceholder-iphoneos:placeholder, name:Any iOS Device, error:iOS 26.2 is not installed. Please download and install the platform from Xcode > Settings > Components. } [ ] Unexpected failure to get Xcode build settings: ProcessException: Process exited abnormally with exit code 64: Command line invocation: /Applications/Xcode-26.3.0.app/Contents/Developer/usr/bin/xcodebuild -project /Users/admin/builds/AEFj1IwjB/0/repo/ios/Runner.xcodeproj -scheme Runner -configuration Release -destination generic/platform=iOS -showBuildSettings BUILD_DIR=/Users/admin/builds/AEFj1IwjB/0/repo/build/ios Build settings from command line: BUILD_DIR = /Users/admin/builds/AEFj1IwjB/0/repo/build/ios 2026-04-06 17:36:56.608 xcodebuild[9023:45646] Writing error result bundle to /var/folders/4p/084k9rr96ld_w60n8rdr0wtm0000gn/T/ResultBundle_2026-06-04_17-36-0056.xcresult xcodebuild: error: Could not configure request to show build settings: Unable to find a destination matching the provided destination specifier: { generic:1, platform:iOS } Ineligible destinations for the "Runner" scheme: { platform:iOS, id:dvtdevice-DVTiPhonePlaceholder-iphoneos:placeholder, name:Any iOS Device, error:iOS 26.2 is not installed. Please download and install the platform from Xcode > Settings > Components. } Command: /usr/bin/arch -arm64e xcrun xcodebuild -project /Users/admin/builds/AEFj1IwjB/0/repo/ios/Runner.xcodeproj -scheme Runner -configuration Release -destination generic/platform=iOS -showBuildSettings BUILD_DIR=/Users/admin/builds/AEFj1IwjB/0/repo/build/ios. [ +66 ms] executing: which security [ +4 ms] executing: which openssl [ +22 ms] executing: security find-identity -p codesigning -v [ +57 ms] 1) <ID> "Apple Distribution: ACME. (<ID>)" 1 valid identities found [ +1 ms] ════════════════════════════════════════════════════════════════════════════════ No valid code signing certificates were found You can connect to your Apple Developer account by signing in with your Apple ID in Xcode and create an iOS Development Certificate as well as a Provisioning Profile for your project by: 1- Open the Flutter project's Xcode target with open ios/Runner.xcworkspace 2- Select the 'Runner' project in the navigator then the 'Runner' target in the project settings 3- Make sure a 'Development Team' is selected under Signing & Capabilities > Team. You may need to: - Log in with your Apple ID in Xcode first - Ensure you have a valid unique Bundle ID - Register your device with your Apple Developer Account - Let Xcode automatically provision a profile for your app 4- Build or run your project again 5- Trust your newly created Development Certificate on your iOS device via Settings > General > Device Management > [your new certificate] > Trust For more information, please visit: https://developer.apple.com/library/content/documentation/IDEs/Conceptual/ AppDistributionGuide/MaintainingCertificates/MaintainingCertificates.html Or run on an iOS simulator without code signing ════════════════════════════════════════════════════════════════════════════════ [ +1 ms] "flutter ipa" took 7,479ms. [ +2 ms] executing: sw_vers -productName [ +8 ms] Exit code 0 from: sw_vers -productName [ ] macOS [ ] executing: sw_vers -productVersion [ +6 ms] Exit code 0 from: sw_vers -productVersion [ ] 26.0 [ ] executing: sw_vers -buildVersion [ +6 ms] Exit code 0 from: sw_vers -buildVersion [ ] 25A354 [ ] executing: uname -m [ +10 ms] Exit code 0 from: uname -m [ ] arm64 [ +20 ms] No development certificates available to code sign app for device deployment [ ] #0 throwToolExit (package:flutter_tools/src/base/common.dart:34:3) #1 XcodeCodeSigningSettings._getCodeSigningBuildSettings (package:flutter_tools/src/ios/code_signing.dart:340:9) <asynchronous suspension> #2 buildXcodeProject (package:flutter_tools/src/ios/mac.dart:322:26) <asynchronous suspension> #3 _BuildIOSSubCommand.runCommand (package:flutter_tools/src/commands/build_ios.dart:986:37) <asynchronous suspension> #4 BuildIOSArchiveCommand.runCommand (package:flutter_tools/src/commands/build_ios.dart:477:50) <asynchronous suspension> #5 FlutterCommand.run.<anonymous closure> (package:flutter_tools/src/runner/flutter_command.dart:1590:27) <asynchronous suspension> #6 AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:154:19) <asynchronous suspension> #7 CommandRunner.runCommand (package:args/command_runner.dart:212:13) <asynchronous suspension> flutter#8 FlutterCommandRunner.runCommand.<anonymous closure> (package:flutter_tools/src/runner/flutter_command_runner.dart:496:9) <asynchronous suspension> flutter#9 AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:154:19) <asynchronous suspension> flutter#10 FlutterCommandRunner.runCommand (package:flutter_tools/src/runner/flutter_command_runner.dart:431:5) <asynchronous suspension> flutter#11 FlutterCommandRunner.run.<anonymous closure> (package:flutter_tools/src/runner/flutter_command_runner.dart:307:33) <asynchronous suspension> flutter#12 run.<anonymous closure>.<anonymous closure> (package:flutter_tools/runner.dart:104:11) <asynchronous suspension> flutter#13 AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:154:19) <asynchronous suspension> flutter#14 main (package:flutter_tools/executable.dart:103:3) <asynchronous suspension> [ ] Running 2 shutdown hooks [ ] Shutdown hooks complete [ +56 ms] exiting with code 1 ``` ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [AI contribution guidelines]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Co-authored-by: Elijah Okoroh <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Beep boop. Your images are optimized!
Your image file size has been reduced by 25% 🎉
Details
📝 docs |
repo | 🙋🏾 issues | 🏪 marketplace
~Imgbot - Part of Optimole family